JAMES-3454 Use a callback mechanism to re-create RabbitMQ auto-delete queues upon reconnections #4085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… queues upon reconnections These queues could have been deleted during the outage, if the outage was long enough, causing fatal errors upon consumes for features like EventBus messaging, task cancellation, task termination.
We rely on an already known queue name, based in the EventBusId
chibenwa
force-pushed
the
rabbit-recovery
branch
from
aff9981
to
cca0d7a
Compare
|
Tested manually on DEV, no James reboot required on DEV |
chibenwa
commented
Nov 25, 2020
...ed/src/main/java/org/apache/james/task/eventsourcing/distributed/CancelRequestQueueName.java
Show resolved
Hide resolved
...va/org/apache/james/task/eventsourcing/distributed/RabbitMQWorkQueueReconnectionHandler.java
Show resolved
Hide resolved
…-delete queues upon reconnections
Arsnael
approved these changes
Nov 25, 2020
LanKhuat
approved these changes
Nov 27, 2020
|
Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires manual testing on DEV before adoption