Trim smtp #711
Closed
Trim smtp #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I do always really like your PRs ^^ If interesting, we can always create ticket while merging don't worry. |
chibenwa
reviewed
Mar 23, 2017
There was a problem hiding this comment.
[Building Java 8 trim-smtp-22f80e98-9e22-45ec-bcab-81aed73ffe08] [ERROR] /james-project/server/container/guice/guice-common/src/main/java/org/apache/james/modules/mailbox/DefaultQuotaModule.java:[25,44] package org.apache.james.mailbox.store.quota does not exist
[Building Java 8 trim-smtp-22f80e98-9e22-45ec-bcab-81aed73ffe08] [ERROR] /james-project/server/container/guice/guice-common/src/main/java/org/apache/james/modules/mailbox/DefaultQuotaModule.java:[26,44] package org.apache.james.mailbox.store.quota does not exist
[Building Java 8 trim-smtp-22f80e98-9e22-45ec-bcab-81aed73ffe08] [ERROR] /james-project/server/container/guice/guice-common/src/main/java/org/apache/james/modules/mailbox/DefaultQuotaModule.java:[27,44] package org.apache.james.mailbox.store.quota does not exist
[Building Java 8 trim-smtp-22f80e98-9e22-45ec-bcab-81aed73ffe08] [ERROR] /james-project/server/container/guice/guice-common/src/main/java/org/apache/james/modules/mailbox/DefaultEventModule.java:[22,44] package org.apache.james.mailbox.store.event does not exist
[Building Java 8 trim-smtp-22f80e98-9e22-45ec-bcab-81aed73ffe08] [ERROR] /james-project/server/container/guice/guice-common/src/main/java/org/apache/james/modules/mailbox/DefaultEventModule.java:[23,44] package org.apache.james.mailbox.store.event does not exist
[Building Java 8 trim-smtp-22f80e98-9e22-45ec-bcab-81aed73ffe08] [ERROR] /james-project/server/container/guice/guice-common/src/main/java/org/apache/james/modules/mailbox/DefaultEventModule.java:[24,44] package org.apache.james.mailbox.store.event does not exist
[Building Java 8 trim-smtp-22f80e98-9e22-45ec-bcab-81aed73ffe08] [ERROR] /james-project/server/container/guice/guice-common/src/main/java/org/apache/james/modules/mailbox/DefaultEventModule.java:[25,44] package org.apache.james.mailbox.store.event does not exist
[Building Java 8 trim-smtp-22f80e98-9e22-45ec-bcab-81aed73ffe08] [ERROR] /james-project/server/container/guice/guice-common/src/main/java/org/apache/james/modules/mailbox/DefaultQuotaModule.java:[36,14] cannot find symbol
[Building Java 8 trim-smtp-22f80e98-9e22-45ec-bcab-81aed73ffe08] symbol: class NoQuotaManager
[Building Java 8 trim-smtp-22f80e98-9e22-45ec-bcab-81aed73ffe08] location: class org.apache.james.modules.mailbox.DefaultQuotaModule
[Building Java 8 trim-smtp-22f80e98-9e22-45ec-bcab-81aed73ffe08] [ERROR] /james-project/server/container/guice/guice-common/src/main/java/org/apache/james/modules/mailbox/DefaultQuotaModule.java:[37,14] cannot find symbol
[Building Java 8 trim-smtp-22f80e98-9e22-45ec-bcab-81aed73ffe08] symbol: class DefaultQuotaRootResolver
[Building Java 8 trim-smtp-22f80e98-9e22-45ec-bcab-81aed73ffe08] location: class org.apache.james.modules.mailbox.DefaultQuotaModule
[Building Java 8 trim-smtp-22f80e98-9e22-45ec-bcab-81aed73ffe08] [ERROR] /james-project/server/container/guice/guice-common/src/main/java/org/apache/james/modules/mailbox/DefaultQuotaModule.java:[38,14] cannot find symbol
[Building Java 8 trim-smtp-22f80e98-9e22-45ec-bcab-81aed73ffe08] symbol: class NoMaxQuotaManager
[Building Java 8 trim-smtp-22f80e98-9e22-45ec-bcab-81aed73ffe08] location: class org.apache.james.modules.mailbox.DefaultQuotaModule
[Building Java 8 trim-smtp-22f80e98-9e22-45ec-bcab-81aed73ffe08] [ERROR] /james-project/server/container/guice/guice-common/src/main/java/org/apache/james/modules/mailbox/DefaultQuotaModule.java:[40,40] cannot find symbol
[Building Java 8 trim-smtp-22f80e98-9e22-45ec-bcab-81aed73ffe08] symbol: class NoMaxQuotaManager
[Building Java 8 trim-smtp-22f80e98-9e22-45ec-bcab-81aed73ffe08] location: class org.apache.james.modules.mailbox.DefaultQuotaModule
[Building Java 8 trim-smtp-22f80e98-9e22-45ec-bcab-81aed73ffe08] [ERROR] /james-project/server/container/guice/guice-common/src/main/java/org/apache/james/modules/mailbox/DefaultQuotaModule.java:[41,37] cannot find symbol
[Building Java 8 trim-smtp-22f80e98-9e22-45ec-bcab-81aed73ffe08] symbol: class NoQuotaManager
[Building Java 8 trim-smtp-22f80e98-9e22-45ec-bcab-81aed73ffe08] location: class org.apache.james.modules.mailbox.DefaultQuotaModule
[Building Java 8 trim-smtp-22f80e98-9e22-45ec-bcab-81aed73ffe08] [ERROR] /james-project/server/container/guice/guice-common/src/main/java/org/apache/james/modules/mailbox/DefaultQuotaModule.java:[42,42] cannot find symbol
[Building Java 8 trim-smtp-22f80e98-9e22-45ec-bcab-81aed73ffe08] symbol: class DefaultQuotaRootResolver
[Building Java 8 trim-smtp-22f80e98-9e22-45ec-bcab-81aed73ffe08] location: class org.apache.james.modules.mailbox.DefaultQuotaModule
[Building Java 8 trim-smtp-22f80e98-9e22-45ec-bcab-81aed73ffe08] [ERROR] /james-project/server/container/guice/guice-common/src/main/java/org/apache/james/modules/mailbox/DefaultEventModule.java:[34,14] cannot find symbol
[Building Java 8 trim-smtp-22f80e98-9e22-45ec-bcab-81aed73ffe08] symbol: class DefaultDelegatingMailboxListener
[Building Java 8 trim-smtp-22f80e98-9e22-45ec-bcab-81aed73ffe08] location: class org.apache.james.modules.mailbox.DefaultEventModule
[Building Java 8 trim-smtp-22f80e98-9e22-45ec-bcab-81aed73ffe08] [ERROR] /james-project/server/container/guice/guice-common/src/main/java/org/apache/james/modules/mailbox/DefaultEventModule.java:[35,50] cannot find symbol
[Building Java 8 trim-smtp-22f80e98-9e22-45ec-bcab-81aed73ffe08] symbol: class DefaultDelegatingMailboxListener
[Building Java 8 trim-smtp-22f80e98-9e22-45ec-bcab-81aed73ffe08] location: class org.apache.james.modules.mailbox.DefaultEventModule
[Building Java 8 trim-smtp-22f80e98-9e22-45ec-bcab-81aed73ffe08] [ERROR] /james-project/server/container/guice/guice-common/src/main/java/org/apache/james/modules/mailbox/DefaultEventModule.java:[35,14] cannot find symbol
[Building Java 8 trim-smtp-22f80e98-9e22-45ec-bcab-81aed73ffe08] symbol: class DelegatingMailboxListener
[Building Java 8 trim-smtp-22f80e98-9e22-45ec-bcab-81aed73ffe08] location: class org.apache.james.modules.mailbox.DefaultEventModule
[Building Java 8 trim-smtp-22f80e98-9e22-45ec-bcab-81aed73ffe08] [ERROR] /james-project/server/container/guice/guice-common/src/main/java/org/apache/james/modules/mailbox/DefaultEventModule.java:[37,14] cannot find symbol
[Building Java 8 trim-smtp-22f80e98-9e22-45ec-bcab-81aed73ffe08] symbol: class SynchronousEventDelivery
[Building Java 8 trim-smtp-22f80e98-9e22-45ec-bcab-81aed73ffe08] location: class org.apache.james.modules.mailbox.DefaultEventModule
[Building Java 8 trim-smtp-22f80e98-9e22-45ec-bcab-81aed73ffe08] [ERROR] /james-project/server/container/guice/guice-common/src/main/java/org/apache/james/modules/mailbox/DefaultEventModule.java:[38,38] cannot find symbol
[Building Java 8 trim-smtp-22f80e98-9e22-45ec-bcab-81aed73ffe08] symbol: class SynchronousEventDelivery
[Building Java 8 trim-smtp-22f80e98-9e22-45ec-bcab-81aed73ffe08] location: class org.apache.james.modules.mailbox.DefaultEventModule
[Building Java 8 trim-smtp-22f80e98-9e22-45ec-bcab-81aed73ffe08] [ERROR] /james-project/server/container/guice/guice-common/src/main/java/org/apache/james/modules/mailbox/DefaultEventModule.java:[38,14] cannot find symbol
[Building Java 8 trim-smtp-22f80e98-9e22-45ec-bcab-81aed73ffe08] symbol: class EventDelivery
[Building Java 8 trim-smtp-22f80e98-9e22-45ec-bcab-81aed73ffe08] location: class org.apache.james.modules.mailbox.DefaultEventModule
This do means that mailbox-store is kind of required for event module and quota module.
I would propose you to create a guice-mailbox-default dependancy where you can put these two modules. Cheers!
| @@ -0,0 +1,9 @@ | |||
| package org.apache.james.modules; | |||
| @@ -0,0 +1,212 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
|
Btw why trim SMTP ? |
Because it's one of the 3 use cases we decided to have in james 3 : full server with distributed backend (C* + ES), full server in single node (JPA + lucene) and smtp only for mailet pipeline. And I don't like pulling tons of useless projects for that use case. More generally, we need to clean up our dependencies and starting with smtp is a good test case. |
There's already a guice-mailbox. I think that default impl could be put there for now. |
chibenwa
approved these changes
Mar 23, 2017
rouazana
reviewed
Mar 23, 2017
|
Merged with added licenses and created Apache ticket |
chibenwa
pushed a commit
to chibenwa/james-project
that referenced
this pull request
Oct 28, 2021
chibenwa
pushed a commit
to chibenwa/james-project
that referenced
this pull request
Oct 28, 2021
chibenwa
pushed a commit
to chibenwa/james-project
that referenced
this pull request
Oct 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
you can review if you want, but I know that there's ticket number missing.