James 2121Disallow creation of several identical mapping #953
Conversation
| @@ -328,6 +328,25 @@ public void sortMappingsShouldPutDomainAliasFirstWhenVariousMappings() { | |||
| .build()); | |||
| } | |||
|
|
|||
| @Test | |||
| public void addMappingShouldThrowWhenMappingAlreadyExists() throws Exception { | |||
There was a problem hiding this comment.
yes, some tests methods are swallowing exceptions and transform them to boolean (false in case of exception or failure). I made the changes to have proper test changes, but they fail with hbase because of the incompatibility of Guave version (cannot found MoreObject). I don't want to go deeper into this, so I let it like that.
There was a problem hiding this comment.
finally the fix was needed, so fixed
| String address = "test@localhost2"; | ||
|
|
||
| assertThat(addMapping(user, domain, address, ADDRESS_TYPE)).isTrue(); | ||
| assertThat(addMapping(user, domain, address, ADDRESS_TYPE)).isFalse(); |
There was a problem hiding this comment.
what line is the when and what line it then ?
There was a problem hiding this comment.
first is when and second is then? :)
no seriously intent would be clearer with exception but see my previous comment
|
sorry I had to rebase to fix some conflicts with guava optionals removing |
|
merged |
And some cosmetic changes