Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISSUE-1048 [PublicAsset] PublicAsset/set create JMAP method #1057

Merged
merged 7 commits into from
May 24, 2024
Merged

ISSUE-1048 [PublicAsset] PublicAsset/set create JMAP method #1057

merged 7 commits into from
May 24, 2024

Conversation

vttranlina
Copy link
Member

resolve #1048

@vttranlina vttranlina mentioned this pull request May 21, 2024
Closed
chibenwa
chibenwa reviewed May 21, 2024
View reviewed changes
...ensions/src/main/scala/com/linagora/tmail/james/jmap/publicAsset/PublicAssetSetService.scala Outdated Show resolved Hide resolved
...ensions/src/main/scala/com/linagora/tmail/james/jmap/publicAsset/PublicAssetSetService.scala Outdated Show resolved Hide resolved
...ensions/src/main/scala/com/linagora/tmail/james/jmap/publicAsset/PublicAssetSetService.scala Outdated Show resolved Hide resolved
...-tests-common/src/main/scala/com/linagora/tmail/james/common/PublicAssetMethodContract.scala Outdated Show resolved Hide resolved
...-tests-common/src/main/scala/com/linagora/tmail/james/common/PublicAssetMethodContract.scala Outdated Show resolved Hide resolved
...ap/extensions/src/main/scala/com/linagora/tmail/james/jmap/method/PublicAssetSetMethod.scala Outdated Show resolved Hide resolved
@vttranlina
Copy link
Member Author

It will be reusing the james-project pr JAMES-3544 Add getUploadMetadata method for UploadRepository + add to UploadResolver

@vttranlina vttranlina force-pushed the publicAssetsSetMethod branch 2 times, most recently from b9cdf2e to 933d890 Compare May 22, 2024 03:38
@vttranlina vttranlina marked this pull request as ready for review May 22, 2024 03:42
@Arsnael
Copy link
Member

Arsnael commented May 22, 2024

[ERROR] /home/jenkins/build/workspace/Tmail_build_PR-1057/tmail-backend/jmap/extensions/src/main/scala/com/linagora/tmail/james/jmap/method/PublicAssetSetMethod.scala:134: value getUploadMetadata is not a member of org.apache.james.jmap.routes.UploadResolver

@chibenwa
Copy link
Member

It will be reusing the james-project pr apache/james-project#2253

Please don't!

This is uneeded.

#1057 (comment)

As expressed there please rely solely on BlobResolvers @vttranlina

@vttranlina
Copy link
Member Author

As expressed there please rely solely on BlobResolvers

But we want to fetch only metadata, while def resolve(blobId: BlobId, mailboxSession: MailboxSession): SMono[Blob] return bytes data content

@vttranlina
Copy link
Member Author

[ERROR] /home/jenkins/build/workspace/Tmail_build_PR-1057/tmail-backend/jmap/extensions/src/main/scala/com/linagora/tmail/james/jmap/method/PublicAssetSetMethod.scala:134: value getUploadMetadata is not a member of org.apache.james.jmap.routes.UploadResolver

Some code is using code of james-project that was not merged. (commit: f165c07)

@chibenwa
Copy link
Member

chibenwa commented May 22, 2024 •
edited
Loading

But we want to fetch only metadata, while def resolve(blobId: BlobId, mailboxSession: MailboxSession): SMono[Blob] return bytes data content

Excuse me we want to copy the content as far as I know....

Because uploads will be cleaned up. Which means underlying blobId will disappear if nothing is done.

@vttranlina
Copy link
Member Author

A lot of changed code, then I will rebase & force push. It will easier

chibenwa
chibenwa reviewed May 23, 2024
View reviewed changes
Copy link
Member

@chibenwa chibenwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there!

chibenwa
chibenwa approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@chibenwa chibenwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the spec please ;-)

quantranhong1999
quantranhong1999 reviewed May 24, 2024
View reviewed changes
Copy link
Member

@quantranhong1999 quantranhong1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall

...-tests-common/src/main/scala/com/linagora/tmail/james/common/PublicAssetMethodContract.scala Outdated Show resolved Hide resolved
...-tests-common/src/main/scala/com/linagora/tmail/james/common/PublicAssetMethodContract.scala Outdated Show resolved Hide resolved
...integration-tests/src/test/java/com/linagora/tmail/james/MemoryPublicAssetSetMethodTest.java Outdated Show resolved Hide resolved
...ensions/src/main/scala/com/linagora/tmail/james/jmap/publicAsset/PublicAssetSetService.scala Outdated Show resolved Hide resolved
@Arsnael
Copy link
Member

Arsnael commented May 24, 2024

Update the spec please ;-)

Initially the spec was good regarding /set create, so please revert that :)

@vttranlina
Copy link
Member Author

The Cassandra repository was merged
I will rebase one more time for the Distributed test

@vttranlina vttranlina merged commit 0508890 into linagora:master May 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chibenwa chibenwa chibenwa approved these changes

@Arsnael Arsnael Arsnael approved these changes

@hungphan227 hungphan227 hungphan227 approved these changes

@quantranhong1999 quantranhong1999 quantranhong1999 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PublicAsset] PublicAsset/set create JMAP method
5 participants
@vttranlina @Arsnael @chibenwa @hungphan227 @quantranhong1999