ISSUE-1042 implement public asset/get method #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[ERROR] Failed to execute goal io.github.evis:scalafix-maven-plugin_2.13:0.1.6_0.9.34:scalafix (scala-check-style) on project jmap-integration-tests-common: Scalafix invoked with errors. Check logs for details. -> [Help 1] |
Arsnael
reviewed
May 22, 2024
...sts-common/src/main/scala/com/linagora/tmail/james/common/PublicAssetGetMethodContract.scala
Outdated
Show resolved
Hide resolved
...sts-common/src/main/scala/com/linagora/tmail/james/common/PublicAssetGetMethodContract.scala
Show resolved
Hide resolved
vttranlina
reviewed
May 23, 2024
...sts-common/src/main/scala/com/linagora/tmail/james/common/PublicAssetGetMethodContract.scala
Outdated
Show resolved
Hide resolved
...sts-common/src/main/scala/com/linagora/tmail/james/common/PublicAssetGetMethodContract.scala
Outdated
Show resolved
Hide resolved
...sts-common/src/main/scala/com/linagora/tmail/james/common/PublicAssetGetMethodContract.scala
Outdated
Show resolved
Hide resolved
...sts-common/src/main/scala/com/linagora/tmail/james/common/PublicAssetGetMethodContract.scala
Outdated
Show resolved
Hide resolved
...ap/extensions/src/main/scala/com/linagora/tmail/james/jmap/method/PublicAssetGetMethod.scala
Outdated
Show resolved
Hide resolved
|
please rebase latest master |
hungphan227
force-pushed
the
ISSUE-1042-Implement-PublicAsset/get-method
branch
from
a60390c
to
7a0c5b4
Compare
chibenwa
approved these changes
May 23, 2024
...sts-common/src/main/scala/com/linagora/tmail/james/common/PublicAssetGetMethodContract.scala
Outdated
Show resolved
Hide resolved
chibenwa
reviewed
May 23, 2024
...sts-common/src/main/scala/com/linagora/tmail/james/common/PublicAssetGetMethodContract.scala
Outdated
Show resolved
Hide resolved
chibenwa
reviewed
May 23, 2024
...map/extensions/src/main/scala/com/linagora/tmail/james/jmap/json/PublicAssetSerializer.scala
Outdated
Show resolved
Hide resolved
|
Read it, fix those last comments and it should be good :) |
...sts-common/src/main/scala/com/linagora/tmail/james/common/PublicAssetGetMethodContract.scala
Show resolved
Hide resolved
...integration-tests/src/test/java/com/linagora/tmail/james/MemoryPublicAssetGetMethodTest.java
Outdated
Show resolved
Hide resolved
tmail-backend/deployment-tests/distributed/src/test/resources/james-conf/jmap.properties
Outdated
Show resolved
Hide resolved
|
Need rebase |
hungphan227
force-pushed
the
ISSUE-1042-Implement-PublicAsset/get-method
branch
from
1f27be9
to
e939324
Compare
...integration-tests/src/test/java/com/linagora/tmail/james/MemoryPublicAssetGetMethodTest.java
Show resolved
Hide resolved
hungphan227
force-pushed
the
ISSUE-1042-Implement-PublicAsset/get-method
branch
from
e939324
to
4a6ebc2
Compare
Arsnael
approved these changes
May 24, 2024
quantranhong1999
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.