Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Communicating I18N to remote servers #2215

Closed
chibenwa opened this issue Oct 5, 2023 · 4 comments
Closed

Communicating I18N to remote servers #2215

chibenwa opened this issue Oct 5, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request regression UX

Comments

@chibenwa
Copy link
Member

chibenwa commented Oct 5, 2023

Why ?

When I send an email outside of TMail,
Remote systems do not get my i18n/language settings

Which means that remote systems won't know which language settings to use.

We need to use a way to communicate i18n/language settings to remote systems.

How ?

Set the following headers:

Accept-Language: fr-FR, en-US
Content-Language: fr-FR

Based of the language settings of the frontend application.

@hoangdat
Copy link
Member

hoangdat commented Oct 23, 2023

Desc:

  • create LocaleInterceptor
  • Locale curentlocale;
  • setLocale(Locale):
    • when create instance LocaleInterceptor: from SharePreferences
    • when change language: from settings

@hoangdat
Copy link
Member

@chibenwa how to verify it?

@chibenwa
Copy link
Member Author

https://oncommit-tmail.linagora.com/

image

Not the case today!

(Email composed in tmail, email replied in tmail, email forwarded in tmail)

image

No Accept-Language and no Content-Language...

@hoangdat
Copy link
Member

**** me!. Hi @dab246 , please add these to Email headers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request regression UX
Projects
None yet
Development

No branches or pull requests

3 participants