Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TW-1584: Sent files in room #1706

Merged
merged 5 commits into from
Apr 25, 2024
Merged

TW-1584: Sent files in room #1706

merged 5 commits into from
Apr 25, 2024

Conversation

Te-Z
Copy link
Contributor

@Te-Z Te-Z commented Apr 16, 2024 •
edited

Ticket:

#1584

Edit: For sync between file tab and chat download, we didn't found the perfect solution but if a download is in progress for example starting from file tab, when clicking on file in chat screen it will display the right download status.

Demo:

Web

Capture.video.du.22-04-2024.15.29.30.webm

Mobile (android):

screen-20240422-155645.mp4

@github-actions GitHub Actions
Copy link

This PR has been deployed to https://linagora.github.io/twake-on-matrix/1706

@hoangdat
Copy link
Member

please apply the same style with design

image

@hoangdat
Copy link
Member

please demo for the case of encrypted room also

@sherlockvn
Copy link
Collaborator

im testing ios for you @Te-Z

@sherlockvn
Copy link
Collaborator

sherlockvn commented Apr 17, 2024 •
edited by Te-Z

RPReplay_Final1713338782.MP4
  • style in IOS is not correct
  • Show download icon when file is not downloaded
  • open file in ios is freeze ?
  • Nice to have, files in divided for each month like design

@sherlockvn
Copy link
Collaborator

You can test the styles of file in ios in web responsive mode

@Te-Z
Copy link
Contributor Author

Te-Z commented Apr 19, 2024

RPReplay_Final1713338782.MP4

  • style in IOS is not correct
  • Show download icon when file is not downloaded
  • open file in ios is freeze ?
  • Nice to have, files in divided for each month like design

Ticket created to debug iOS: https://github.com/orgs/linagora/projects/6/views/1?pane=issue&itemId=60332401

@hoangdat
Copy link
Member

IMO, we should keep the height of file tile consistent: in downloading or in normal. Avoid height is changing

Screen.Recording.2024-04-22.at.05.41.39.mov

@nqhhdev nqhhdev changed the title Tw 1584/sent files in room TW-1584: Sent files in room Apr 22, 2024
@nqhhdev
Copy link
Member

nqhhdev commented Apr 22, 2024 •
edited

  • Missing borders
Screenshot 2024-04-22 at 09 04 00

@nqhhdev
Copy link
Member

nqhhdev commented Apr 22, 2024

IMO: should you take a look at this ticket after finished current ticket

#1715

@sherlockvn
Copy link
Collaborator

What about show in chat feature ?

@sherlockvn
Copy link
Collaborator

What about show in chat feature ?

Create another ticket: #1718

@sherlockvn
Copy link
Collaborator

sherlockvn commented Apr 23, 2024 •
edited

Tested on web:

  • When start downloading in files tab, then return to the chat, the status of file is not correct x (in both web + mobile)
  • When start download in chat, then go to chat details, file tabs, the status of file is correct ✔
  • open file in ios is freeze ? -> not anymore ✔
  • style in IOS is correct ✔
RPReplay_Final1713839942.MP4

@sherlockvn
Copy link
Collaborator

Hey, because of this ticket block some other tickets, if you can fix it quick please prioritize this one first, if not you can rebase and do part II after this ticket.

@Te-Z Te-Z force-pushed the TW-1584/sent-files-in-room branch from aee2dbf to 68df4c2 Compare April 24, 2024 07:10
@Te-Z
Copy link
Contributor Author

Te-Z commented Apr 24, 2024

Hey, because of this ticket block some other tickets, if you can fix it quick please prioritize this one first, if not you can rebase and do part II after this ticket.

Hi @sherlockvn I didn't found any quick solution to synchronize the download status from files tab to chat screen, but it works when downloading on chat screen and going on files tab. I will do it in an other ticket so this one won't block others

This was referenced Apr 24, 2024
Open
Closed
@hoangdat
Copy link
Member

IMO, please keep file size also after downloading

image

@hoangdat
Copy link
Member

overall, LGTM

@Te-Z
Copy link
Contributor Author

Te-Z commented Apr 25, 2024

IMO, please keep file size also after downloading

image

done @hoangdat
Capture d’écran du 2024-04-25 08-07-16

@hoangdat
Copy link
Member

hi, please rebase @Te-Z

@Te-Z Te-Z force-pushed the TW-1584/sent-files-in-room branch from 1eb53db to a73b61b Compare April 25, 2024 11:46
@hoangdat hoangdat merged commit aa535e3 into main Apr 25, 2024
3 checks passed
@hoangdat hoangdat deleted the TW-1584/sent-files-in-room branch April 25, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nqhhdev nqhhdev nqhhdev left review comments

@hoangdat hoangdat hoangdat approved these changes

@sherlockvn sherlockvn sherlockvn approved these changes

@dab246 dab246 Awaiting requested review from dab246 dab246 is a code owner

@hieutbui hieutbui Awaiting requested review from hieutbui hieutbui is a code owner

@tddang-linagora tddang-linagora Awaiting requested review from tddang-linagora tddang-linagora is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Te-Z @hoangdat @sherlockvn @nqhhdev