Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column display consistency #1

Closed
aaronware opened this issue Apr 19, 2016 · 6 comments
Closed

Column display consistency #1

aaronware opened this issue Apr 19, 2016 · 6 comments
Assignees
Labels
Milestone

Comments

@aaronware
Copy link
Collaborator

Wondering if we should keep the visuals similar between 1 column displays and multiple column displays. At least with the grey header etc even if the 1 column display doesn't need the "more" accordion.

Single Column

vs

Multi Column

@aaronware
Copy link
Collaborator Author

@erroneous5000 Let me know what you think about this as well.

@erroneous5000
Copy link

I think we could even keep more options on a one col with the gray full
across. The CSS text field is causing a bit of a double border.

On Tue, Apr 19, 2016 at 11:25 AM, Aaron Ware notifications@github.com
wrote:

@erroneous5000 https://github.com/erroneous5000 Let me know what you
think about this as well.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#1 (comment)

Eric Beltram
Production Designer
ebeltram@linchpinagency.com


Linchpin
_Connecting Brand + Design + Interactive_Office: (401) 305-5228
http://linchpin.agency

@aaronware
Copy link
Collaborator Author

I'm cool with that too. Helps with consistency of UI as well

@maxinacube
Copy link
Collaborator

Yeah the 1 column display is output differently, I need to go in and make sure that all the components and styles carry over the same

@aaronware
Copy link
Collaborator Author

@maxinacube Do you want to try to get this into 1.1? I did a bunch of style changes/tweaks that addresses some of the things mentioned here. The drawers could use some help but we could do it as a point release of 1.1 as well

@aaronware
Copy link
Collaborator Author

I implemented this for 1.1

@aaronware aaronware added this to the 1.1 milestone Sep 27, 2016
desrosj added a commit that referenced this issue Feb 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants