Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some tests failing with python 3.6 and 3.7 #163

Closed
nyanloutre opened this issue Dec 5, 2018 · 2 comments
Closed

Some tests failing with python 3.6 and 3.7 #163

nyanloutre opened this issue Dec 5, 2018 · 2 comments

Comments

@nyanloutre
Copy link

Hello,

I noticed that tests don't pass on python 3.6 and 3.7 with the following error:

======================================================================
FAIL: test_invalid_data (qrcode.tests.test_release.UpdateManpageTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/nix/store/zls48cbfg36i19pvn1gvprxyvwyginhk-python3-3.7.1/lib/python3.7/unittest/mock.py", line 1191, in patched
    return func(*args, **keywargs)
  File "/build/qrcode-6.0/qrcode/tests/test_release.py", line 20, in test_invalid_data
    mock_file.assert_called()
  File "/nix/store/zls48cbfg36i19pvn1gvprxyvwyginhk-python3-3.7.1/lib/python3.7/unittest/mock.py", line 792, in assert_called
    raise AssertionError(msg)
AssertionError: Expected 'open' to have been called.

======================================================================
FAIL: test_no_change (qrcode.tests.test_release.UpdateManpageTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/nix/store/zls48cbfg36i19pvn1gvprxyvwyginhk-python3-3.7.1/lib/python3.7/unittest/mock.py", line 1191, in patched
    return func(*args, **keywargs)
  File "/build/qrcode-6.0/qrcode/tests/test_release.py", line 31, in test_no_change
    mock_file.assert_called()
  File "/nix/store/zls48cbfg36i19pvn1gvprxyvwyginhk-python3-3.7.1/lib/python3.7/unittest/mock.py", line 792, in assert_called
    raise AssertionError(msg)
AssertionError: Expected 'open' to have been called.

It could be related to this line:

sys.version_info[0] == 3 and sys.version_info[1] < 6,

@SmileyChris
Copy link
Member

Fixed in 3505606, just hadn't rolled a new release. Will do that now.

@nyanloutre
Copy link
Author

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants