CI updates #145
Closed
CI updates #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into development Conflicts: firmware/open_evse/open_evse.h
To ensure that we get the correct versions for each different build, probably a better way to do this...
…t of the build process anyway so removed
…into ci_updates
glynhudson
suggested changes
Dec 1, 2021
platformio.ini
Outdated
| upload_flags = "-e -B0.5" | ||
| version = 7.1.5 | ||
| eu_build_flags = | ||
| -D PP_AUTO_AMPACITY |
There was a problem hiding this comment.
PP_AUTO_AMPACITY only applies to emonevse and emonevse_3ph environments, NOT openevse_eu
There was a problem hiding this comment.
PP_AUTO_AMPACITY should be removed from common eu_build_flags and only applied to emonevse and emonevse_3ph environments. Sorry, I can't see how I can make this change myself.
Only apply `PP_AUTO_AMPACITY` to `emonevse`
…into ci_updates
|
Nice, this all looks good to me now. Although I can't test it fully until it's merged. However, I always compile using platformIO using the same flags, so the build artefacts should be the same 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Charges to merge various forks and implement CI to build the different configs
Fixes #144