-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installation problem on Windows 7 #8
Comments
Not so sure about the ParseError, but looks like we might want to follow the approach we took in LibCURL and use exclusively the |
I checked, and The ParseError was due to my mistakenly invoking But I do need to both rename or copy the DLL to |
I was suggesting changing this line https://github.com/lindahua/LightXML.jl/blob/master/deps/build.jl#L6 to |
It works! Some problems running some of the tests, I think due to deprecated @test_throws, and the fact that rtxt in create.jl contains some ‘\r’ characters that are not present in the string(xdoc) variable to which it is being compared—probably a Windows-only problem that may have escaped attention until now. From: Tony Kelman [mailto:notifications@github.com] I was suggesting changing this line https://github.com/lindahua/LightXML.jl/blob/master/deps/build.jl#L6 to libxml2 = library_dependency("libxml2-2") then you shouldn't need to rename the file or mess with DL_LOAD_PATH, hopefully. — |
Thanks for the quick action. It now works fine, except for a single deprecation warning when running the tests: julia> include("test/parse.jl") WARNING: @test_throws without an exception type is deprecated
in backtrace at error.jl:30 Ptr{Void} @0x0000000000000000 To fix it I had to change line 103 of tests/parse.jl to @test_throws LightXML.XMLAttributeNotFound attribute(xb2, "wrongattr"; required=true) It needed the module prefix or it would complain that the exception type was undefined. From: Dahua Lin [mailto:notifications@github.com] I made a change in dd22ca7 dd22ca7 following @tkelman https://github.com/tkelman 's suggestion. Would you please checkout the latest master branch and see whether it works in windows? I don't have a windows machine to test it. — |
Thanks @lindahua! Whoops, I can confirm the |
Adding the line @windows_only rtxt=replace(rtxt, "\r", "") just before the @Assert line in create.jl and cdata.jl eliminated the test failures for me. |
Safer to make that |
Hmm, just tried installing on a new machine and got this error:
Then I tried checking out the master version and got the same error. Playing with this a bit, I found that replacing https://github.com/lindahua/LightXML.jl/blob/master/deps/build.jl#L8 with
seems to fix the problem. I'm happy to submit a PR, if desired. --Peter |
@simonp0420 I have a commit that makes exactly that change pending in #9 @lindahua I can understand if you're busy, but ignoring your github notifications is a major problem. Would you be willing to give a few other people commit access to this repository, or migrate it to JuliaLang so it can be maintained by the community? |
@IainNZ or @StefanKarpinski what's the standard practice for moving a repository to the organization, assuming Dahua agrees? |
I am willing to transfer the package. But I need the temporary permission. |
Paging @ViralBShah or @JeffBezanson or @StefanKarpinski |
The package has been transferred to JuliaLang. |
Great, thanks! It seems I got #9 a little bit wrong, I'm getting |
I don't have windows machines. Hopefully somebody working with Windows can figure this out. |
I think I got it resolved on master, I made a couple small commits (hope you don't mind). Can you verify that master still works okay on existing platforms? |
I can confirm that master passes all the tests on CentOS 6.4, Julia 0.3.2. |
@simonp0420 thanks, I'll tag a new version then |
Thanks very much, @tkelman! Tagged version now installs and runs smoothly in Windows :). |
Does it pass |
The tests also run smooth as silk. Thanks again! |
I'm trying to install LightXML on Julia Version 0.3.0-prerelease+3225 (2014-05-27 03:45 UTC) x86_64-w64-mingw32. The Pkg.add session looks like this:
It doesn't appear to be installing the libxml2.dll binary dependency. When I try to use the module I get the following:
I have several libxml2.dll files on my hard drive, installed by various other Windows applications. I tried to see which one occurs first in my PATH by using
which
at the REPL shell mode:So I'm guessing that Julia is finding the DLL installed by Graphviz, which is unsuitable for some reason; perhaps it's 32-bit rather than 64-bit.
Poking around in c:\home\simonp.julia\v0.3\WinRPM\deps\usr\x86_64-w64-mingw32\sys-root\mingw\bin, I see that there is a file there named libxml2-2.dll. I see from the build script in LightXML that this is an alternative name for libxml.dll. I checked DL_LOAD_PATH and it is empty, so I executed
followed by
Since this didn't work, I copied libxml2-2.dll in this directory to libxml2.dll in the same directory and tried again:
Progress! So I tried parsing the XML file stored in the test subdirectory:
Hopefully, my fumbling attempts will help you to pinpoint the problem and its solution.
@tkelman (pinging you since I see you did the WinRPM PR)
Thanks,
--Peter
The text was updated successfully, but these errors were encountered: