Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhance:#1021]: monthly partitioning of indices #1022

Closed
wants to merge 3 commits into from

Conversation

joyant
Copy link
Contributor

@joyant joyant commented Apr 28, 2024

What problem does this PR solve?

Issue Number: #1021

Problem Summary:
This submission doesn't implement concurrent index reading due to ongoing refactoring in PR #1015.

Check List

Tests

  • Unit test
  • Integration test
  • No code

@joyant joyant closed this Apr 29, 2024
@joyant joyant reopened this Apr 29, 2024
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 82.45614% with 30 lines in your changes are missing coverage. Please review.

Project coverage is 94.21%. Comparing base (f740235) to head (f56cd06).

❗ Current head f56cd06 differs from pull request most recent head cd28e60. Consider uploading reports for the commit cd28e60 to get more accurate results

Files Patch % Lines
index/metric_index_segment.go 82.85% 13 Missing and 11 partials ⚠️
tsdb/shard.go 62.50% 2 Missing and 1 partial ⚠️
tsdb/data_family.go 50.00% 1 Missing and 1 partial ⚠️
query/operator/tag_value_collect.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1022      +/-   ##
==========================================
- Coverage   94.38%   94.21%   -0.18%     
==========================================
  Files         400      401       +1     
  Lines       24682    24822     +140     
==========================================
+ Hits        23296    23385      +89     
- Misses       1133     1164      +31     
- Partials      253      273      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joyant joyant closed this May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant