Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhance]: de-register broker node when shutdown #900

Merged
merged 1 commit into from
Jan 28, 2023

Conversation

stone1100
Copy link
Member

@stone1100 stone1100 commented Jan 28, 2023

What problem does this PR solve?

Issue Number: #892

Problem Summary:

  • de-register broker node when server shutdown

Check List

Tests

  • Unit test
  • Integration test
  • No code

@stone1100 stone1100 added the enhancement New feature or request label Jan 28, 2023
@codecov
Copy link

codecov bot commented Jan 28, 2023

Codecov Report

Merging #900 (d4a37d8) into main (1432652) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #900   +/-   ##
=======================================
  Coverage   95.91%   95.91%           
=======================================
  Files         408      408           
  Lines       24774    24776    +2     
=======================================
+ Hits        23762    23764    +2     
  Misses        726      726           
  Partials      286      286           
Impacted Files Coverage Δ
app/broker/runtime.go 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@stone1100 stone1100 merged commit 2d85535 into lindb:main Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant