Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opt]: print error message when handle http request failure #934

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

stone1100
Copy link
Member

@stone1100 stone1100 commented Mar 14, 2023

What problem does this PR solve?

Issue Number: #932

Problem Summary:
print error message in access log when handle http request failure

Check List

Tests

  • Unit test
  • Integration test
  • No code

@stone1100 stone1100 added the enhancement New feature or request label Mar 14, 2023
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #934 (a78f4e8) into main (c0465e3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head a78f4e8 differs from pull request most recent head 48845c6. Consider uploading reports for the commit 48845c6 to get more accurate results

@@           Coverage Diff           @@
##             main     #934   +/-   ##
=======================================
  Coverage   96.30%   96.30%           
=======================================
  Files         416      416           
  Lines       25320    25324    +4     
=======================================
+ Hits        24385    24389    +4     
  Misses        664      664           
  Partials      271      271           
Impacted Files Coverage Δ
pkg/http/middleware/access_log.go 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant