Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhance]: need to check rollup Interval when memory database refreshing #947

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

stone1100
Copy link
Member

@stone1100 stone1100 commented Mar 28, 2023

What problem does this PR solve?

Issue Number: #945

Problem Summary:
if rollup interval < memory database TTL, using rollup interval to check if need to flush

Check List

Tests

  • Unit test
  • Integration test
  • No code

@stone1100 stone1100 added the enhancement New feature or request label Mar 28, 2023
@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #947 (fee4f40) into main (0f5d845) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head fee4f40 differs from pull request most recent head 0af4904. Consider uploading reports for the commit 0af4904 to get more accurate results

@@           Coverage Diff           @@
##             main     #947   +/-   ##
=======================================
  Coverage   96.30%   96.30%           
=======================================
  Files         416      416           
  Lines       25348    25353    +5     
=======================================
+ Hits        24412    24417    +5     
  Misses        665      665           
  Partials      271      271           
Impacted Files Coverage Δ
tsdb/data_family.go 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@stone1100 stone1100 merged commit 0717000 into lindb:main Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant