Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI mis-counts completed recipes when you Run AutoPkg Now #333

Closed
jazzace opened this issue Apr 17, 2015 · 2 comments
Closed

GUI mis-counts completed recipes when you Run AutoPkg Now #333

jazzace opened this issue Apr 17, 2015 · 2 comments
Labels
Milestone

Comments

@jazzace
Copy link

jazzace commented Apr 17, 2015

If you opt to Run AutoPkg Now (button in Schedule tab), the resulting progress bar correctly reports the number of total recipes but over-reports the number of recipes completed. Examples attached (the one with "StopProcessingIf" in it may give a clue as to what extra messages are being counted as recipes). This bug seems to have appeared in the 1.2 release and is still present in 1.2.1. Tested on both 10.9.5 (13F1077) and 10.10.3 (14D136).
stop-processing-if

miscounting-recipes

@eahrold
Copy link
Collaborator

eahrold commented Apr 18, 2015

@jazzace,
Thanks for the report.

Currently the increment is based on a string from the AutoPkg stdout containing the word "Processing", we should definitely switch that to a string that begins with with "Processing ".

I suspect it will help. I'll update this ASAP.
Thanks again.

@homebysix
Copy link
Collaborator

Yeah, looks like this is definitely related to the StopProcessingIf processor, which I see in the AppStoreApp series of recipes:

        <dict>
            <key>Processor</key>
            <string>StopProcessingIf</string>
            <key>comment</key>
            <string>If a package has already been built with this version and ID (and "force_pkg_build" is False), we're done.</string>
            <key>Arguments</key>
            <dict>
                <key>predicate</key>
                <string>pkg_build_matches == YES</string>
            </dict>
        </dict>

Thanks @eahrold for handling it!

@homebysix homebysix added this to the 1.2.3 milestone Apr 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants