Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix goreleaser config #490

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

suzuki-shunsuke
Copy link
Contributor

@suzuki-shunsuke suzuki-shunsuke commented Jul 2, 2024

  • chore(goreleaser): set version: 2
  • chore(goreleaser): replace brews.foloder with brews.directory

What does this change

Give a summary of the change, and how it affects end-users. It's okay to copy/paste your commit messages.

For example if it introduces a new flag or modifies a commands output, give an example of you running the command and showing real output here.

Fixed GoReleaser config's errors.

https://github.com/lindell/multi-gitter/actions/runs/9755716855/job/26924701362

  • only configurations files on version: 2 are supported, yours is version: 0, please update your configuration
  ⨯ release failed after 0s                  error=only configurations files on version: 2 are supported, yours is version: 0, please update your configuration
Error: The process '/opt/hostedtoolcache/goreleaser-action/2.0.1/x64/goreleaser' failed with exit code 1

The release of v0.52.1 failed, so this pull request fixes the error.

Furthermore, this pull request fixes another error too.

$ goreleaser check
  ⨯ command failed                                   error=yaml: unmarshal errors:
  line 76: field folder not found in type config.Homebrew

https://goreleaser.com/deprecations/#brewsfolder

What issue does it fix

Closes # (issue)

If there is not an existing issue, please make sure we have context on why this change is needed. .

Notes for the reviewer

Put any questions or notes for the reviewer here.

Checklist

  • Made sure the PR follows the CONTRIBUTING.md guidelines
  • Tests if something new is added

Fixed the error.

https://github.com/lindell/multi-gitter/actions/runs/9755716855/job/26924701362

```
  • only configurations files on version: 2 are supported, yours is version: 0, please update your configuration
  ⨯ release failed after 0s                  error=only configurations files on version: 2 are supported, yours is version: 0, please update your configuration
Error: The process '/opt/hostedtoolcache/goreleaser-action/2.0.1/x64/goreleaser' failed with exit code 1
```
Fixed the error.

```console
$ goreleaser check
  ⨯ command failed                                   error=yaml: unmarshal errors:
  line 76: field folder not found in type config.Homebrew
```

https://goreleaser.com/deprecations/#brewsfolder
@suzuki-shunsuke
Copy link
Contributor Author

suzuki-shunsuke commented Jul 2, 2024

Test

I've confirmed goreleaser check succeeded.

$ goreleaser -v     
  ____       ____      _
 / ___| ___ |  _ \ ___| | ___  __ _ ___  ___ _ __
| |  _ / _ \| |_) / _ \ |/ _ \/ _` / __|/ _ \ '__|
| |_| | (_) |  _ <  __/ |  __/ (_| \__ \  __/ |
 \____|\___/|_| \_\___|_|\___|\__,_|___/\___|_|
goreleaser: Deliver Go Binaries as fast and easily as possible
https://goreleaser.com

GitVersion:    2.0.1
GitCommit:     684c1805864e5f29acc204e34e1770eb74918d15
GitTreeState:  false
BuildDate:     2024-06-11T01:45:52Z
BuiltBy:       goreleaser
GoVersion:     go1.22.4
Compiler:      gc
ModuleSum:     h1:Wx2peRnvixEBRKxU6T0Gh+3wlire+Jv2IOW5eNPan3U=
Platform:      darwin/arm64
$ goreleaser check
  • checking                                 path=.goreleaser.yml
  • 1 configuration file(s) validated
  • thanks for using goreleaser!

@suzuki-shunsuke suzuki-shunsuke marked this pull request as ready for review July 2, 2024 07:57
@lindell lindell merged commit 4491a1a into lindell:master Jul 2, 2024
9 checks passed
@lindell
Copy link
Owner

lindell commented Jul 2, 2024

Thanks! I don't currently have access to a computer, so I very much appreciate this fix atm!

@suzuki-shunsuke suzuki-shunsuke deleted the chore-fix-goreleaser-config branch July 2, 2024 08:53
Copy link
Contributor

github-actions bot commented Jul 2, 2024

Included in release v0.52.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants