Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move rel() to priors #99

Open
1 of 5 tasks
lindeloev opened this issue Jan 5, 2021 · 0 comments
Open
1 of 5 tasks

Move rel() to priors #99

lindeloev opened this issue Jan 5, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@lindeloev
Copy link
Owner

lindeloev commented Jan 5, 2021

Implementing #90, I now see that rel() becomes cumbersome to support henceforth (it already was) and that it becomes somewhat ambiguous for categorical predictors. Users seem to misunderstand it anyway.

  • Remove all code for rel()
  • Add support for prior = list(groupX_2 = "groupX_1+ DEFAULT", catY_3 = "catY_1 + dnorm(0, 1) T(0, )"). The returned parameter should be the distribution part so the JAGS code needs to be like catY_1_return ~ dnorm(0, 1) T(0, ); catY_1 = catY_1 + catY_3
  • Add explicit informative deprecation error if a user uses rel().
  • Update code documentation
  • Update vignettes

An advantage of this approach is that it expands functionality: allows relativity across segments (not just the former), it allows percentage-wise relativity (divide), etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant