Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build fail with GCC 5.3.1 #22

Closed
davephillips opened this issue Jan 29, 2018 · 2 comments
Closed

build fail with GCC 5.3.1 #22

davephillips opened this issue Jan 29, 2018 · 2 comments

Comments

@davephillips
Copy link

Fedora 23 Linux
Rack 0.5.x

I can solve some C++ issues but not this one:

g++ -fPIC -I../../include -I../../dep/include -DVERSION=0.5.210 -MMD -g -O3 -march=nocona -ffast-math -fno-finite-math-only -Wall -Wextra -Wno-unused-parameter -DARCH_LIN -Wsuggest-override -std=c++11 -c -o build/src/MS20Filter.cpp.o src/MS20Filter.cpp
In file included from src/dsp/MS20zdf.hpp:4:0,
from src/MS20Filter.cpp:1:
src/dsp/DSPSystem.hpp:38:9: error: ‘virtual’ can only be specified for functions
};
^
src/dsp/DSPSystem.hpp:44:9: error: ‘virtual’ can only be specified for functions
};
^
src/dsp/DSPSystem.hpp:50:9: error: ‘virtual’ can only be specified for functions
};
^
../../compile.mk:53: recipe for target 'build/src/MS20Filter.cpp.o' failed
make: *** [build/src/MS20Filter.cpp.o] Error 1

@davephillips
Copy link
Author

NB: I resolved the issue for the moment by removing the virtual specifier. Everything compiles now, but I have no idea if my changes will affect performance. Please advise if there's a better fix, thanks.

@lindenbergresearch
Copy link
Owner

Hi Dave,

nevermind - all under construction - I am experimenting with an DSP abstraction layer... I will use a developer branch soon instead of the master to avoid such troubles ;)
Dropping the 'virtual' is absolutely correct :)

Thanks for reporting.

Patrick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants