Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the binary smaller by compressing the dictionary #126

Merged

Conversation

higumachan
Copy link
Contributor

@higumachan higumachan commented Dec 24, 2021

I made the binary smaller by compressing the dictionary. (Instead, the decompression runtime is taken first).
I implemented this feature in my lindera-js with the aim of making the executable file smaller.

If you guys are interested in this feature, I'd like to include it in this repository by using the features flag to toggle it on and off.

achivement:

cargo build --release
ls -lah target/release/

the execute file target/release/lindera size is 72M to 11M.
but the bench-constructor result is slower than no compress.

bench-constructor       time:   [28.210 ms 28.319 ms 28.431 ms] 
bench-constructor       time:   [590.35 ms 591.92 ms 593.58 ms]                              

@mosuka
Copy link
Member

mosuka commented Dec 25, 2021

Nice work! I'm looking forward to the status changing to "Ready for review".

@higumachan
Copy link
Contributor Author

Thank you, then.

  • Switching at feature flag
  • Documentation

I'll switch from Draft to Wait Review when the above two things are done.

@higumachan higumachan marked this pull request as ready for review December 25, 2021 08:20
@higumachan
Copy link
Contributor Author

@mosuka
I think I'm done working on this PR.

If you would like to review it, please do so.

@mosuka mosuka self-requested a review December 28, 2021 06:45
Copy link
Member

@mosuka mosuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@mosuka mosuka merged commit 45a3ea4 into lindera-morphology:master Dec 28, 2021
@mosuka
Copy link
Member

mosuka commented Dec 28, 2021

@higumachan Thanks for your great contribution!

@higumachan higumachan deleted the feature/dictionary_compression branch December 29, 2021 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants