-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the binary smaller by compressing the dictionary #126
Make the binary smaller by compressing the dictionary #126
Conversation
Nice work! I'm looking forward to the status changing to "Ready for review". |
Thank you, then.
I'll switch from Draft to Wait Review when the above two things are done. |
@mosuka If you would like to review it, please do so. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@higumachan Thanks for your great contribution! |
I made the binary smaller by compressing the dictionary. (Instead, the decompression runtime is taken first).
I implemented this feature in my lindera-js with the aim of making the executable file smaller.
If you guys are interested in this feature, I'd like to include it in this repository by using the features flag to toggle it on and off.
achivement:
the execute file
target/release/lindera
size is72M
to11M
.but the
bench-constructor
result is slower than no compress.