Remove the Tokio dependency #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bors bot
added a commit
to meilisearch/milli
that referenced
this pull request
Mar 22, 2022
476: Rollback meilisearch-tokenizer version r=Kerollmops a=irevoire Lindera often fails to download some data from google drive we can’t compile consistently meilisearch / milli. We can’t bump to the latest version (that moved out of google drive) either because lindera uses reqwest with openssl with no way of configuring it our benchmarks were not able to run. The latter issue should be fixed by lindera-morphology/lindera#164. Co-authored-by: Irevoire <tamo@meilisearch.com>
mosuka
approved these changes
Mar 22, 2022
|
@Kerollmops |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the dependency to tokio, reqwest, h2 and hyper in the build script and replaces them by ureq which is way simpler and is largely sufficient to download one file at compile time.
Doing this shrinks down the total number of dependencies from 172 to 117 and reduces the compilation time of lindera-ipadic from 1m 24s to 1m 17s on my Macbook Pro m1.
This PR also marked the HTTP client and compression libraries as optional for when they will not be used by the build script. This shrinks down the compilation time from 12.76s to 10.23s when the feature e.g. ipadic is not set. And that is only for one sub-crate, I have done that on all of them.