Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #47

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Dev #47

merged 1 commit into from
Oct 19, 2023

Conversation

lindsaygelle
Copy link
Owner

Description

Reworked a few methods to be in line with their intended programming counterparts. Functions such as Filter and Reduce were modifying the original Slice instead of returning a new version. These have been reworked to create new Slice instances. Have added Modify to update the current pointer in place.

Related Issue

Fixing up some unintended/incorrect implementations of the intended code. Added more broad unit tests. Added some additional functions to replace previous.

Changes Made

Added new code examples to the README.md file for documentation examples, added more verbose tests for existing and new methods, reworked various functions to better match common programming implementations.

How to Test

Standard Go tests.

Checklist

  • I have followed the coding style guidelines of the project.
  • My code passes all existing unit tests.
  • I have added new unit tests to cover the changes where applicable.
  • I have updated the documentation to reflect the changes.
  • My changes do not introduce any new warnings or errors.
  • I have tested my changes thoroughly.

Copy link
Owner Author

@lindsaygelle lindsaygelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐳🆗

@lindsaygelle lindsaygelle merged commit 5723085 into main Oct 19, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant