Add a compilation flag to enable precomputed lookup tables #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juh0ng
approved these changes
May 31, 2024
redfast00
reviewed
May 31, 2024
| @@ -330,3 +342,5 @@ void aes_generic_gen_tables(void) | |||
| FT3[i] = ROTL8(FT2[i]); | |||
There was a problem hiding this comment.
Since FT1..3 can be trivially calculated from FT0 (it's just a rotate), maybe it's useful to define FT1..3 in terms of FT0 with a #define macro: that way, we save another 3KB from RAM/ROM.
There was a problem hiding this comment.
Yes, indeed, that's possible, and was almost supported by the code with minor changes.
I added the feature with a compile flag to address this case, it can work in combination with the flag for enabling static const LUT.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds a compilation flag to enable
static constlookup tables for AES, which reduces the size of the.datasegment.