Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix a bug where a connection is not closed immediatley when HTTP/2 PI…
…NG write fails (#2699) Motivation: If a connection is closed unexpectedly due to a network problem, the remote peer does not receive closing signals such as GOAWAY frame and the connection is alive until cleaned up due to request timeout, idle timeout, or PING failure. When PING write fails, KeepAliveHandler tries to close the connection, which takes as long as the idle timeout. Because the idle timeout is configured as `gracefulShutdownTimeoutMillis` for Netty Http2ConnectionHandler. https://github.com/line/armeria/blob/fec9fb833275eba59eb9afaf25fc8b7c28132f80/core/src/main/java/com/linecorp/armeria/server/Http2ServerConnectionHandler.java#L56-L62 Modifications: * Close a connection immediately if KeepAliveHandler is closing. Result: A dead connection is cleaned up immediately when PING write fails.
- Loading branch information