Skip to content

Commit

Permalink
Suggestion: Set intellij project icon (#5467)
Browse files Browse the repository at this point in the history
Motivation:

There is no intellij project icon.

Modifications:

- Add icon to `.idea/icon.svg`
- (Copied and edited [this logo file](https://github.com/line/armeria/blob/main/site/src/design/armeria_icon.svg) to trim space and make square)

Result:

- Looks good

<img width="468" alt="Screenshot 2024-02-15 at 9 03 32 PM" src="https://github.com/line/armeria/assets/11611397/8a87e959-9009-469d-8262-10d23cf686ae">

example


<img width="1035" alt="Screenshot 2024-02-15 at 9 14 31 PM" src="https://github.com/line/armeria/assets/11611397/9aa4d105-6ee0-45c5-ad5a-68e6f6c30bdf">

Project icon can be set from welcome page

<!--
Visit this URL to learn more about how to write a pull request description:
https://armeria.dev/community/developer-guide#how-to-write-pull-request-description
-->
  • Loading branch information
sh-cho committed Mar 12, 2024
1 parent 75d5af1 commit 53d7cad
Show file tree
Hide file tree
Showing 2 changed files with 66 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ hs_err_pid*
.gradle

# IntelliJ
.idea
**/.idea/*
!.idea/icon.svg
*.iml
*.iws
*.ipr
Expand Down
64 changes: 64 additions & 0 deletions .idea/icon.svg
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 53d7cad

Please sign in to comment.