Skip to content

Commit

Permalink
Correctly configure percentile precision in MoreMeters (#4047)
Browse files Browse the repository at this point in the history
Motivation:

While `MoreMeters.distStatCfg` specifies that Micrometer's default `percentilePrecision` is not accurate enough, the correct/better value is never actually used in `MoreMeters`.

Modifications:

- Set `percentilePrecision` in `newTimer()` and `newDistributionSummary()`

Result:

- Meters created by `MoreMeters` are now using more accurate percentiles
  • Loading branch information
KarboniteKream committed Jan 27, 2022
1 parent a4c622e commit 5ff371e
Showing 1 changed file with 2 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ public static DistributionSummary newDistributionSummary(MeterRegistry registry,
.tags(tags)
.publishPercentiles(distStatCfg.getPercentiles())
.publishPercentileHistogram(distStatCfg.isPercentileHistogram())
.percentilePrecision(distStatCfg.getPercentilePrecision())
.distributionStatisticBufferLength(distStatCfg.getBufferLength())
.distributionStatisticExpiry(distStatCfg.getExpiry());

Expand Down Expand Up @@ -151,6 +152,7 @@ public static Timer newTimer(MeterRegistry registry, String name, Iterable<Tag>
.minimumExpectedValue(minExpectedValue)
.publishPercentiles(distStatCfg.getPercentiles())
.publishPercentileHistogram(distStatCfg.isPercentileHistogram())
.percentilePrecision(distStatCfg.getPercentilePrecision())
.distributionStatisticBufferLength(distStatCfg.getBufferLength())
.distributionStatisticExpiry(distStatCfg.getExpiry())
.register(registry);
Expand Down

0 comments on commit 5ff371e

Please sign in to comment.