Address comments

line · May 14, 2021 · ae031ce · ae031ce
1 parent f4de651
commit ae031ce
Showing 1 changed file with 11 additions and 12 deletions.
diff --git a/core/src/main/java/com/linecorp/armeria/internal/common/logging/LoggingDecorators.java b/core/src/main/java/com/linecorp/armeria/internal/common/logging/LoggingDecorators.java
@@ -52,22 +52,21 @@ public static void logWhenComplete(
             Logger logger, RequestContext ctx,
             Consumer<RequestOnlyLog> requestLogger, Consumer<RequestLog> responseLogger) {
         final boolean isTransientService = isTransientService(ctx);
-        final CompletableFuture<RequestOnlyLog> requestCompletionFuture = ctx.log().whenRequestComplete();
+        final CompletableFuture<RequestOnlyLog> requestCompletionFuture;
         if (!isTransientService) {
-            requestCompletionFuture.thenAccept(requestLogger).exceptionally(e -> {
-                try (SafeCloseable ignored = ctx.push()) {
-                    logger.warn("{} Unexpected exception while logging request: ", ctx, e);
-                }
-                return null;
+            requestCompletionFuture = ctx.log().whenRequestComplete().thenApply(log -> {
+                requestLogger.accept(log);
+                return log;
             });
         } else {
-            requestCompletionFuture.exceptionally(e -> {
-                try (SafeCloseable ignored = ctx.push()) {
-                    logger.warn("{} Unexpected exception while logging request: ", ctx, e);
-                }
-                return null;
-            });
+            requestCompletionFuture = ctx.log().whenRequestComplete();
         }
+        requestCompletionFuture.exceptionally(e -> {
+            try (SafeCloseable ignored = ctx.push()) {
+                logger.warn("{} Unexpected exception while logging request: ", ctx, e);
+            }
+            return null;
+        });
         ctx.log().whenComplete().thenAccept(responseLogger).exceptionally(e -> {
             try (SafeCloseable ignored = ctx.push()) {
                 logger.warn("{} Unexpected exception while logging response: ", ctx, e);