prefer more explicit removeResponse method

line · Nov 23, 2021 · dca247c · dca247c
1 parent 7d207f9
commit dca247c
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/core/src/main/java/com/linecorp/armeria/client/Http2ResponseDecoder.java b/core/src/main/java/com/linecorp/armeria/client/Http2ResponseDecoder.java
@@ -134,7 +134,7 @@ public void onStreamHalfClosed(Http2Stream stream) {}
     public void onStreamClosed(Http2Stream stream) {
         goAwayHandler.onStreamClosed(channel(), stream);
 
-        final HttpResponseWrapper res = getResponse(streamIdToId(stream.id()), true);
+        final HttpResponseWrapper res = removeResponse(streamIdToId(stream.id()));
         if (res == null) {
             return;
         }

diff --git a/core/src/main/java/com/linecorp/armeria/client/HttpResponseDecoder.java b/core/src/main/java/com/linecorp/armeria/client/HttpResponseDecoder.java
@@ -93,11 +93,6 @@ final HttpResponseWrapper getResponse(int id) {
         return responses.get(id);
     }
 
-    @Nullable
-    final HttpResponseWrapper getResponse(int id, boolean remove) {
-        return remove ? removeResponse(id) : getResponse(id);
-    }
-
     @Nullable
     final HttpResponseWrapper removeResponse(int id) {
         if (closing) {