Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not log a GOAWAY message at WARN if connection is over. #1401

Closed
trustin opened this issue Oct 22, 2018 · 1 comment
Closed

Do not log a GOAWAY message at WARN if connection is over. #1401

trustin opened this issue Oct 22, 2018 · 1 comment
Labels
Milestone

Comments

@trustin
Copy link
Member

trustin commented Oct 22, 2018

Saw this log:

01:50:19 [WARN] (Http2GoAwayListener.java:65) [id: 0x2f91f9a1, L:... ! R:...]
Sent a GOAWAY frame: lastStreamId=1, errorCode=INTERNAL_ERROR(2), debugData="
type: n/a, message: n/a, 
cause: io.netty.channel.unix.Errors$NativeIoException: syscall:writev(..) failed: Broken pipe"

There's no reason to send a GOAWAY frame to a closed channel.

@trustin trustin added the defect label Oct 22, 2018
@trustin trustin added this to the 0.74.1 milestone Oct 22, 2018
@trustin
Copy link
Member Author

trustin commented Oct 23, 2018

Fixed via #1403

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant