Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HttpTracingClient/ServiceBuilder #1792

Closed
trustin opened this issue May 27, 2019 · 0 comments · Fixed by #1840
Closed

Add HttpTracingClient/ServiceBuilder #1792

trustin opened this issue May 27, 2019 · 0 comments · Fixed by #1840
Labels
new feature

Comments

@trustin
Copy link
Member

trustin commented May 27, 2019

A user currently has to build Tracing by him/herself and set currentTraceContext manually. We could add HttpTracingClient/ServiceBuilder which builds a Tracing for a user:

HttpTracingService.builder()
                  .localServiceName("myService")
                  .spanReporter(...)
                  .build();

// Alternatively
HttpTracingService.builder()
                  .tracing(Tracing.newBuilder()...build())
                  .build();
@minwoox minwoox mentioned this issue Jun 14, 2019
Merged
trustin pushed a commit that referenced this issue Jul 2, 2019
@minwoox @trustin
Add brave module which supersedes zipkin module (#1840)
fd8b57e 
Motivation:
As @anuraaga comments, it's not Zipkin, but Brave we're interfacing.

Modifications:
- Move `internal.tracing` package in `zipkin` module to `internal.brave` in `brave` module.
- Deprecation
  - `armeria-brave` supersedes `armeria-zipkin`.
  - `BraveClient` and `BraveService` supersedes `TracingHttpClient` and `TracingHttpService`
  - `RequestContextCurrentTraceContext` in `brave` supersedes the same class in `zipkin` 
- Fix a bug where `decorateScope` is not called.
- Miscellaneous
  - Add missing `equals` in `DefaultAggregatedHttpRequest`
  - Update Brave from 5.6.5 -> 5.6.6

Result:
- `armeria-brave` supersedes `armeria-zipkin`.
- A user can now decorate a scope when it's created.
- Close #1792 anyway.
- Brave 5.6.5 -> 5.6.6
fmguerreiro pushed a commit to fmguerreiro/armeria that referenced this issue Sep 19, 2020
@minwoox @trustin
Add brave module which supersedes zipkin module (line#1840)
2adf87e 
Motivation:
As @anuraaga comments, it's not Zipkin, but Brave we're interfacing.

Modifications:
- Move `internal.tracing` package in `zipkin` module to `internal.brave` in `brave` module.
- Deprecation
  - `armeria-brave` supersedes `armeria-zipkin`.
  - `BraveClient` and `BraveService` supersedes `TracingHttpClient` and `TracingHttpService`
  - `RequestContextCurrentTraceContext` in `brave` supersedes the same class in `zipkin` 
- Fix a bug where `decorateScope` is not called.
- Miscellaneous
  - Add missing `equals` in `DefaultAggregatedHttpRequest`
  - Update Brave from 5.6.5 -> 5.6.6

Result:
- `armeria-brave` supersedes `armeria-zipkin`.
- A user can now decorate a scope when it's created.
- Close line#1792 anyway.
- Brave 5.6.5 -> 5.6.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add brave module which supersedes zipkin module minwoox/armeria
1 participant
@trustin