Fix the uri of ArmeriaServerHttpRequest to contain the base url #1904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The uri of `ServerHttpRequest` in Spring Web flux contains the base url. Also a negative value of "max-age" from "set-cookie" means do "max-age" attribute, we shouldn't set it. Modification: - Add the base url when `ArmeriaServerHttpRequest` is created. - Do not set max-age from set-cookie when the value is negative Result: - More Spring integration
Codecov Report
@@ Coverage Diff @@
## master #1904 +/- ##
============================================
- Coverage 73.26% 73.25% -0.02%
- Complexity 8973 8977 +4
============================================
Files 794 794
Lines 35162 35170 +8
Branches 4317 4322 +5
============================================
+ Hits 25762 25764 +2
- Misses 7200 7201 +1
- Partials 2200 2205 +5
Continue to review full report at Codecov.
|
trustin
approved these changes
Jul 16, 2019
...ure/src/test/java/com/linecorp/armeria/spring/web/reactive/ArmeriaServerHttpRequestTest.java
Outdated
Show resolved
Hide resolved
|
Special thanks to @jinsankim for reporting this issue and providing useful hints and sample application. ❤️ |
ikhoon
reviewed
Jul 16, 2019
...nfigure/src/main/java/com/linecorp/armeria/spring/web/reactive/ArmeriaServerHttpRequest.java
Show resolved
Hide resolved
ikhoon
approved these changes
Jul 16, 2019
fmguerreiro
pushed a commit
to fmguerreiro/armeria
that referenced
this pull request
Sep 19, 2020
…#1904) Motivation: The uri of `ServerHttpRequest` in Spring Web flux contains the base URL. Also, a negative value of "max-age" from "set-cookie" means no "max-age" attribute, we shouldn't set it. Modification: - Add the base URL when `ArmeriaServerHttpRequest` is created. - Do not set max-age from set-cookie when the value is negative Result: - Spring integration works as expected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The uri of
ServerHttpRequestin Spring Web flux contains the base URL.Also, a negative value of "max-age" from "set-cookie" means no "max-age" attribute, we shouldn't set it.
Modification:
ArmeriaServerHttpRequestis created.Result: