Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the uri of ArmeriaServerHttpRequest to contain the base url #1904

Merged
merged 2 commits into from
Jul 16, 2019
Merged

Fix the uri of ArmeriaServerHttpRequest to contain the base url #1904

merged 2 commits into from
Jul 16, 2019

Commits on Jul 15, 2019

  1. Fix the uri of ArmeriaServerHttpRequest to contain the base url 

    Motivation:
The uri of `ServerHttpRequest` in Spring Web flux contains the base url.
Also a negative value of "max-age" from "set-cookie" means do "max-age" attribute, we shouldn't set it.

Modification:
- Add the base url when `ArmeriaServerHttpRequest` is created.
- Do not set max-age from set-cookie when the value is negative

Result:
- More Spring integration
    @minwoox
    minwoox committed Jul 15, 2019
    Configuration menu
    Copy the full SHA
    3cab6ac View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2019

  1. Remove system.err

    @minwoox
    minwoox committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    65a09f4 View commit details
    Browse the repository at this point in the history