Add sampling to the exceptions without stack traces. #2105
Labels
Milestone
Comments
|
The sensible default would be like edit: I guess we will need some benchmark to determine the default rate which does not increase the total overhead more than 1%. |
trustin
added a commit
to trustin/armeria
that referenced
this issue
Sep 24, 2019
Motivation: Like we can specify a string to instantiate a `Backoff`, we could also specify a specification string to instantiate a `Sampler`, which will be useful when sampling policy must be configurable. Modifications: - Add `Sampler.of()` - Miscellaneous: - Minor documentation clean-up of `Backoff.of()` Result: - A user can create a `Sampler` from a specification string, which means sampling policy settings can be configurable from a configuration file, a system property or other external sources. - Can start to work on line#2105
trustin
added a commit
that referenced
this issue
Sep 25, 2019
Motivation: Like we can specify a string to instantiate a `Backoff`, we could also specify a specification string to instantiate a `Sampler`, which will be useful when sampling policy must be configurable. Modifications: - Add `Sampler.of()` - Miscellaneous: - Minor documentation clean-up of `Backoff.of()` Result: - A user can create a `Sampler` from a specification string, which means sampling policy settings can be configurable from a configuration file, a system property or other external sources. - Can start to work on #2105
|
Closed via #2111 |
eugene70
pushed a commit
to eugene70/armeria
that referenced
this issue
Oct 16, 2019
Motivation: Like we can specify a string to instantiate a `Backoff`, we could also specify a specification string to instantiate a `Sampler`, which will be useful when sampling policy must be configurable. Modifications: - Add `Sampler.of()` - Miscellaneous: - Minor documentation clean-up of `Backoff.of()` Result: - A user can create a `Sampler` from a specification string, which means sampling policy settings can be configurable from a configuration file, a system property or other external sources. - Can start to work on line#2105
fmguerreiro
pushed a commit
to fmguerreiro/armeria
that referenced
this issue
Sep 19, 2020
Motivation: Like we can specify a string to instantiate a `Backoff`, we could also specify a specification string to instantiate a `Sampler`, which will be useful when sampling policy must be configurable. Modifications: - Add `Sampler.of()` - Miscellaneous: - Minor documentation clean-up of `Backoff.of()` Result: - A user can create a `Sampler` from a specification string, which means sampling policy settings can be configurable from a configuration file, a system property or other external sources. - Can start to work on line#2105
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In production, it is currently recommended to run Armeria servers with the
verboseExceptionsflag disabled to reduce the overhead ofThrowable.fillInStackTrace(). However, this makes it hard for users to determine the root cause of the exceptions such asResponseTimeoutExceptionorAbortedStreamException.Instead of choosing between all or nothing, we could define some expression for defining a
Sampler, e.t.random=0.1orrateLimited=1The text was updated successfully, but these errors were encountered: