Fix a bug where a connection is not closed immediatley when HTTP/2 PING write fails #2699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…G write fail Motivation: If a connection is closed unexpectedly by network shutdown, the opposite does not receive close signals such as GOAWAY frame and the connection is alive until cleaning up by request timeout, idle timeout, or PING fail. When PING writes fail, KeepAliveHandler tries to close the connection, which takes for the idle timeout. Because it is configured as `gracefulShutdownTimeoutMillis` for Netty Http2ConnectionHandler. https://github.com/line/armeria/blob/fec9fb833275eba59eb9afaf25fc8b7c28132f80/core/src/main/java/com/linecorp/armeria/server/Http2ServerConnectionHandler.java#L56-L62 Modifications: * Close a connection immediately if KeepAliveHandler is closing. Result: Clean up a dead connection immediately when PING write fails.
Codecov Report
@@ Coverage Diff @@
## master #2699 +/- ##
============================================
- Coverage 72.68% 72.68% -0.01%
- Complexity 11312 11315 +3
============================================
Files 1001 1001
Lines 44297 44302 +5
Branches 5494 5498 +4
============================================
+ Hits 32197 32200 +3
+ Misses 9306 9304 -2
- Partials 2794 2798 +4
Continue to review full report at Codecov.
|
trustin
approved these changes
May 12, 2020
trustin
changed the title
|
Good job, @ikhoon 😄 |
fmguerreiro
pushed a commit
to fmguerreiro/armeria
that referenced
this pull request
Sep 19, 2020
…NG write fails (line#2699) Motivation: If a connection is closed unexpectedly due to a network problem, the remote peer does not receive closing signals such as GOAWAY frame and the connection is alive until cleaned up due to request timeout, idle timeout, or PING failure. When PING write fails, KeepAliveHandler tries to close the connection, which takes as long as the idle timeout. Because the idle timeout is configured as `gracefulShutdownTimeoutMillis` for Netty Http2ConnectionHandler. https://github.com/line/armeria/blob/fec9fb833275eba59eb9afaf25fc8b7c28132f80/core/src/main/java/com/linecorp/armeria/server/Http2ServerConnectionHandler.java#L56-L62 Modifications: * Close a connection immediately if KeepAliveHandler is closing. Result: A dead connection is cleaned up immediately when PING write fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
If a connection is closed unexpectedly due to a network problem,
the remote peer does not receive closing signals such as GOAWAY frame and
the connection is alive until cleaned up due to request timeout, idle timeout, or PING failure.
When PING write fails, KeepAliveHandler tries to close the connection, which takes as long as the idle timeout.
Because the idle timeout is configured as
gracefulShutdownTimeoutMillisfor Netty Http2ConnectionHandler.armeria/core/src/main/java/com/linecorp/armeria/server/Http2ServerConnectionHandler.java
Lines 56 to 62 in fec9fb8
Modifications:
Result:
A dead connection is cleaned up immediately when PING write fails.