Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customizing health-check delay dynamically #2728

Open
trustin opened this issue May 19, 2020 · 0 comments
Open

Allow customizing health-check delay dynamically #2728

trustin opened this issue May 19, 2020 · 0 comments

Comments

@trustin
Copy link
Member

trustin commented May 19, 2020

From @adriancole at #1910:

forgive the drive by but I guess the state of throwing exception is more a
"fail fast" thing which could be configured and if not then we can consider
how to handle temporary absence of all endpoints.

I dont recall the implementation here but iirc in finagle when fail fast is
off.. the down endpoints, maybe all, would be individual countdown buckets
..

https://github.com/twitter/finagle/blob/76f791937fb0e4ec8ec8cdea48ae001f0591071a/finagle-core/src/main/scala/com/twitter/finagle/liveness/FailureAccrualPolicy.scala

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant