Add builder for OAuth1aToken #2770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Related line#2680 (comment) The current implementation for building OAuth 1a token isn't convinient. Modifcations: - Add `OAuth1aTokenBuilder`. Result: - You can now easily create `OAuth1aToken`.
trustin
reviewed
Jun 4, 2020
core/src/main/java/com/linecorp/armeria/common/auth/OAuth1aTokenBuilder.java
Outdated
Show resolved
Hide resolved
ikhoon
reviewed
Jun 4, 2020
core/src/main/java/com/linecorp/armeria/common/auth/OAuth1aToken.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #2770 +/- ##
============================================
+ Coverage 72.66% 72.92% +0.25%
- Complexity 11746 11901 +155
============================================
Files 1032 1043 +11
Lines 45883 46201 +318
Branches 5723 5765 +42
============================================
+ Hits 33340 33690 +350
+ Misses 9610 9562 -48
- Partials 2933 2949 +16 Continue to review full report at Codecov.
|
trustin
reviewed
Jun 5, 2020
core/src/main/java/com/linecorp/armeria/common/auth/OAuth1aToken.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/linecorp/armeria/common/auth/OAuth1aTokenBuilder.java
Outdated
Show resolved
Hide resolved
| @@ -125,13 +137,60 @@ public OAuth1aTokenBuilder version(String version) { | |||
| } | |||
|
|
|||
| /** | |||
| * Sets additional (or user-defined) parameters. | |||
| * Sets additional parameters. If the specified {@code additionals} has pre-defined parameters, | |||
| * the parameters are set automatically to this builder and removed from the {@code additionals}. | |||
| */ | |||
| public OAuth1aTokenBuilder additionals(Map<String, String> additionals) { | |||
There was a problem hiding this comment.
This method is not only for additional parameters but any parameters including pre-defined ones. Perhaps we should rename it to putAll()? We could also add methods like put(CharSequence, CharSequence).
There was a problem hiding this comment.
Thanks, added put() and putAll(). I didn't use CharSequence though because I feel it's too much.
If it's necessary, jut let me know. 😉
trustin
approved these changes
Jun 5, 2020
ikhoon
approved these changes
Jun 6, 2020
core/src/main/java/com/linecorp/armeria/common/auth/OAuth1aTokenBuilder.java
Outdated
Show resolved
Hide resolved
core/src/test/java/com/linecorp/armeria/common/auth/OAuth1aTokenTest.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/linecorp/armeria/common/auth/OAuth1aTokenBuilder.java
Show resolved
Hide resolved
|
Thanks a lot, @minwoox |
|
Thanks for reviewing. 😉 |
fmguerreiro
pushed a commit
to fmguerreiro/armeria
that referenced
this pull request
Sep 19, 2020
Motivation: Related: line#2680 (comment) The current implementation for building OAuth 1a token isn't convenient. Modifcations: - Add `OAuth1aTokenBuilder`. Result: - You can now easily create `OAuth1aToken`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Related #2680 (comment)
The current implementation for building OAuth 1a token isn't convenient.
Modifcations:
OAuth1aTokenBuilder.Result:
OAuth1aToken.