Log the exception while making request and response log strings. #3043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: It's not easy to recognize what is the problem if an exception is raised while making request response log strings because there's no log for the exception and of course, request and response logs are not left as well. Modification: - Log the exception that is raised while making request response log strings. Result: - You can now get the log of the exception which is raised while making requst and response logs.
Codecov Report
@@ Coverage Diff @@
## master #3043 +/- ##
============================================
- Coverage 73.40% 73.36% -0.05%
- Complexity 12289 12290 +1
============================================
Files 1066 1066
Lines 47583 47615 +32
Branches 6001 6007 +6
============================================
+ Hits 34930 34934 +4
- Misses 9606 9627 +21
- Partials 3047 3054 +7 Continue to review full report at Codecov.
|
ikhoon
reviewed
Sep 4, 2020
core/src/main/java/com/linecorp/armeria/internal/common/logging/LoggingDecorators.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/linecorp/armeria/internal/common/logging/LoggingDecorators.java
Outdated
Show resolved
Hide resolved
trustin
approved these changes
Sep 9, 2020
ikhoon
reviewed
Sep 9, 2020
| }) | ||
| .build(delegate); | ||
| loggingClient.execute(ctx, req); | ||
| verify(logger).warn(eq("Unexpected exception while logging request: "), any(CompletionException.class)); |
There was a problem hiding this comment.
Suggested change
| verify(logger).warn(eq("Unexpected exception while logging request: "), any(CompletionException.class)); | |
| verify(logger).warn(contains("Unexpected exception while logging request: "), any(CompletionException.class)); |
This test was failed https://ci.appveyor.com/project/line/armeria/builds/35079753/job/5fn7wowbu1vdvwwf#L1498 😉
There was a problem hiding this comment.
Oops forgot to fix the test. 🤣
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
It's not easy to recognize what is the problem if an exception is raised while making request and response log strings
because there's no log for the exception and of course, request and response logs are not left as well.
Modification:
Result: