New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a method to do a no-op subscribe to a StreamMessage
#4145
Labels
Milestone
Comments
Hello @jrhee17 馃槃 I would like to handle this issue. May I try it? |
All yours @wooseongshin ! Thanks 馃憤 |
How about naming the method as |
Thank you for the good suggestion @trustin I'll apply it like that! Work is delayed due to Corona 馃ぇ I will try to solve it as soon as possible ! |
Merged
trustin
pushed a commit
that referenced
this issue
Apr 18, 2022
Motivation: Provide a method to do a no-op subscribe to a `StreamMessage` #4145 Some users may want to use `StreamMessage#peek` to perform some options, but not want the entire message to be in memory (as is done by `StreamMessage#collect`). The functionality may be similar to `Flux#subscribe` Modifications: - Add no-op `subscribe` to `StreamMessage` Result: - we can now use no-op `subscribe` for draining data from `StreamMessage`. - Closes #4145 Co-authored-by: Ikhun Um <ih.pert@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Credit to @trustin for suggesting this idea 馃憤
Some users may want to use
StreamMessage#peek
to perform some options, but not want the entire message to be in memory (as is done byStreamMessage#collect
). The functionality may be similar toFlux#subscribe
In order to achieve this, users may need to do something like the following which can be cumbersome
e.g.
We could add a method to
StreamMessage
that performs the above in a convenient matter.StreamMessage.java
The text was updated successfully, but these errors were encountered: