Correctly throw WriteTimeoutException for requests without content
#4259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4259 +/- ##
============================================
- Coverage 73.38% 73.37% -0.02%
+ Complexity 16985 16982 -3
============================================
Files 1451 1451
Lines 64034 64033 -1
Branches 8039 8039
============================================
- Hits 46994 46983 -11
- Misses 12952 12953 +1
- Partials 4088 4097 +9
Continue to review full report at Codecov.
|
jrhee17
changed the title
WriteTimeoutException for requests without contentWriteTimeoutException for requests without content
ikhoon
approved these changes
May 19, 2022
trustin
approved these changes
Jun 1, 2022
minwoox
pushed a commit
that referenced
this pull request
Jul 5, 2022
Motivation:
- Currently, there is no easy way to create integration tests which simulate certain behaviors (e.g. `WriteTimeoutException`)
- #4259
- Users may also want to customize behavior like throttling, fault injection, etc. for clients.
Modifications:
- Add `CHANNEL_PIPELINE_CUSTOMIZER` to `ClientFactoryOptions`, which is a consumer on `ChannelPipeline`
- I'm a little skeptical of adding these methods to `ClientFactoryBuilder`, `Flags` until more users want this feature.
- Call `HttpClientFactory#channelPipelineCustomizer` right before `channel#connect`, giving users to customize the pipeline at the last minute.
- Add a unit test which simulates write timeout behavior.
- Rename `invokeProxyConnectFailed` to `maybeHandleProxyFailure` to better represent what the method is doing.
Result:
- Closes #3907
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
WriteTimeoutExceptionis defined as an exception thrown if the first message write doesn't complete within a specified time. This specification holds for requests with bodies.However, requests without bodies never throw a
WriteTimeoutExceptionbecause:armeria/core/src/main/java/com/linecorp/armeria/internal/common/stream/FixedStreamMessage.java
Lines 141 to 148 in 5a2c720
armeria/core/src/main/java/com/linecorp/armeria/client/HttpRequestSubscriber.java
Line 261 in 5a2c720
Modifications:
HttpRequestSubscriber#cancelTimeoutwhen the subscription on the request is complete.Result:
WriteTimeoutExceptionmay not be thrown for header-only requests #4255Verified the following test passes:
https://github.com/jrhee17/armeria/blob/13c2c60e60b6109531b363d55d09ab6af7de432c/core/src/test/java/com/linecorp/armeria/client/TimeoutTest.java
Also created a PR which helps simulate slow writes as a follow-up:
#4260