Add debug logs for http2 stream errors #4515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrhee17
force-pushed
the
cleanup/log-stream-error
branch
from
19f0d12
to
53e331e
Compare
minwoox
approved these changes
Nov 3, 2022
Comment on lines
115
to
117
| if (logger.isDebugEnabled()) { | ||
| logger.debug("{} HTTP/2 connection error:", ctx.channel(), cause); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (logger.isDebugEnabled()) { | |
| logger.debug("{} HTTP/2 connection error:", ctx.channel(), cause); | |
| } | |
| logger.debug("{} HTTP/2 connection error:", ctx.channel(), cause); |
We use isDebugEnabled when it takes cost to create instances that are logged.
There was a problem hiding this comment.
Ah, I thought that there would be some cost if a throwable was passed in.
Went through the code and verified at least logback terminates early 👍
ikhoon
reviewed
Nov 3, 2022
| @@ -111,13 +112,20 @@ protected final void onConnectionError(ChannelHandlerContext ctx, boolean outbou | |||
|
|
|||
| handlingConnectionError = true; | |||
| if (Exceptions.isExpected(cause) || isGoAwaySentException(cause, connection())) { | |||
| // Ignore silently. | |||
| logger.debug("{} HTTP/2 connection error:", ctx.channel(), cause); | |||
There was a problem hiding this comment.
As you know the error is safely ignored. How about setting the level to trace to log the cause only when users really want to delve into something?
Codecov ReportBase: 74.05% // Head: 74.06% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #4515 +/- ##
============================================
+ Coverage 74.05% 74.06% +0.01%
- Complexity 18167 18177 +10
============================================
Files 1536 1537 +1
Lines 67378 67426 +48
Branches 8520 8526 +6
============================================
+ Hits 49894 49939 +45
- Misses 13412 13418 +6
+ Partials 4072 4069 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ikhoon
approved these changes
Nov 4, 2022
ikhoon
added a commit
to ikhoon/armeria
that referenced
this pull request
Nov 10, 2022
ikhoon
added a commit
that referenced
this pull request
Nov 11, 2022
Motivation: When the target release version changed from 1.21.0 to 1.20.3, some PRs were already merged into the master branch. So their milestone should be changed and the release notes also need to be updated. Modifications: - Add #4515, #4507, #4484 and #4492 to the release notes. Result: Update the missing issues and PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We sometimes encounter situations where HTTP/2 header frames are lost due to an exception.
Although a RST frame is sent in this case, remotes are still able to send data for the offending stream, which ends up in error logs which armeria doesn't understand.
e.g.
Although normally it might be noisy to be alerted of such failures, it might be useful to view such logs when debugging.
Modifications:
StreamErrorResult: