You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Users need to use MoreMeters.setDistributionStatisticConfig(config) to specify the distribution config.
That means users cannot configure different configs depending on the client. Using the static class is also not intuitive and not the Armeria style which uses a builder for setting configuration.
We can probably do:
Motivation:
As of now, users need to use
`MoreMeters.setDistributionStatisticConfig(config)` to specify the
distribution config.
It prevents users from configuring different configs depending on the
client.
This PR is to resolve above issue.
Modifications:
- Add `distributionStatisticConfig` getter to `FlagsProvider` and
`DefaultFlagsProvider`
- Add `distributionStatisticConfig` setter and getter to
`AbstractMetricCollectingBuilder`
Result:
- Closes#4781
- User can specify custom Distribution Config with builder
<!--
Visit this URL to learn more about how to write a pull request
description:
https://armeria.dev/community/developer-guide#how-to-write-pull-request-description
-->
---------
Co-authored-by: minux <minu.song@linecorp.com>
Co-authored-by: jrhee17 <guins_j@guins.org>
Co-authored-by: Ikhun Um <ikhun.um@linecorp.com>
Users need to use
MoreMeters.setDistributionStatisticConfig(config)
to specify the distribution config.That means users cannot configure different configs depending on the client. Using the static class is also not intuitive and not the Armeria style which uses a builder for setting configuration.
We can probably do:
We can also add the getter to
FlagsProvider
:The text was updated successfully, but these errors were encountered: