Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a way to enable/disable OpenSSL at the ClientFactory level #4949

Open
ikhoon opened this issue Jun 14, 2023 · 2 comments
Open

Provide a way to enable/disable OpenSSL at the ClientFactory level #4949

ikhoon opened this issue Jun 14, 2023 · 2 comments
Labels
new feature

Comments

@ikhoon
Copy link
Contributor

ikhoon commented Jun 14, 2023 •
edited

OpenSSL is automatically enabled if it is available. There is no way to disable OpenSSL for a specific client because it can be disabled globally by -Dcom.linecorp.armeria.useOpenSsl=false.

There is a requirement to disable OpenSSL for a client which needs to use a bad cipher that is only supported by JDK SSL to communicate with a legacy HTTPS server.

ClientFactory
  .builder()
  .useOpenSsl(false)
  .build();
@seonWKim
Copy link
Contributor

May I take this issue 🥺

@ikhoon
Copy link
Contributor Author

ikhoon commented Jun 15, 2023

Yes, please!

@seonWKim seonWKim mentioned this issue Jun 15, 2023
Open
This was referenced Jul 12, 2023
Closed
Merged
jrhee17 added a commit that referenced this issue Apr 3, 2024
@seonWKim @ikhoon
@jrhee17 @minwoox
Add TlsEngineType enum (#5029)
33ab3bb 
Motivation:

Add `TlsEngineType` to let users choose the type of tls engine. (Using
`Flags`)

Modifications:

- Add `TlsEngineType` enum 
- Deprecate `useOpenSsl` 

Result:

- Related to #<[4949](#4949)>.
- Related to
#4962 (comment)
- `TlsEngineType` is added 
- `useOpenSsl` is deprecated 

<!--
Visit this URL to learn more about how to write a pull request
description:

https://armeria.dev/community/developer-guide#how-to-write-pull-request-description
-->

---------

Co-authored-by: Ikhun Um <ih.pert@gmail.com>
Co-authored-by: Ikhun Um <ikhun.um@linecorp.com>
Co-authored-by: jrhee17 <guins_j@guins.org>
Co-authored-by: minwoox <songmw725@gmail.com>
Co-authored-by: minux <minu.song@linecorp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ikhoon @seonWKim