Add `TlsEngineType` enum #5029

seonWKim · 2023-07-13T01:11:33Z

Motivation:

Add TlsEngineType to let users choose the type of tls engine. (Using Flags)

Modifications:

Add TlsEngineType enum
Deprecate useOpenSsl

Result:

Related to #<4949>.
Related to Allow useOpenSsl to be configured by ClientFactoryBuilder #4962 (comment)
TlsEngineType is added
useOpenSsl is deprecated

core/src/main/java/com/linecorp/armeria/common/FlagsProvider.java

core/src/main/java/com/linecorp/armeria/common/Flags.java

ikhoon · 2023-07-31T05:31:43Z

core/src/main/java/com/linecorp/armeria/common/Flags.java

    }

    private static void setUseOpenSslAndDumpOpenSslInfo() {
-        final boolean useOpenSsl = getValue(FlagsProvider::useOpenSsl, "useOpenSsl");
-        if (!useOpenSsl) {
+        TLS_ENGINE_TYPE = getValue(FlagsProvider::tlsEngineType, "tlsEngineType");


For smooth migration, -Dcom.linecorp.armeria.useOpenSsl=false needs to return TlsEngineType.JDK if no TlsEngineType is specified by a user. Otherwise, an OpenSSL engine is used unexpectedly.

How about adding getUserValue() method that ignores DefaultFlagsProvider's values and returns only user-defined values?

final Boolean useOpenSsl = getUserValue(FlagsProvider::useOpenSsl, "useOpenSsl"); final TlsEngineType tlsEngineType = getUserValue(FlagsProvider::tlsEngineType, "tlsEngineType"); if (useOpenSsl == null) { // Respect tlsEngineType } else if (tlsEngineType == null) { // Respect useOpenSsl } else { // Check if the values of useOpenSsl and tlsEngineType are compatible. }

@ikhoon Thank you for the detailed comment. I've added getUserValue() which ignores DefaultFlagsProvider.

In the case of incompatible useOpenSsl and tlsEngineType, I left a warning log and used the value from tlsEngineType. I chose tlsEngineType instead of useOpenSsl because in that case, user is aware of and using -Dcom.linecorp.armeria.tlsEngineType, so I think it's might be fine to use the value of tlsEngineType.

else { if (useOpenSsl != (tlsEngineType == TlsEngineType.OPENSSL)) { logger.warn("useOpenSsl({}) and tlsEngineType({}) are incompatible, tlsEngineType will be used", useOpenSsl, tlsEngineType); } TLS_ENGINE_TYPE = tlsEngineType; }

minwoox

Looks pretty great! 👍

core/src/main/java/com/linecorp/armeria/common/Flags.java

minwoox · 2023-08-24T07:21:16Z

core/src/main/java/com/linecorp/armeria/common/Flags.java

@@ -1506,6 +1535,29 @@ private static <T> T getValue(Function<FlagsProvider, @Nullable T> method,
        throw new Error();
    }

+    @Nullable
+    private static <T> T getUserValue(Function<FlagsProvider, @Nullable T> method, String flagName) {


This method looks pretty much the same as the above getValue method.
How about removing this method and adding ignoreDefaultFlags to the above method instead?

private static <T> T getValue(Function<FlagsProvider, @Nullable T> method, String flagName, boolean ignoreDefaultFlags, Predicate<T> validator) { for (FlagsProvider provider : FLAGS_PROVIDERS) { if (provider instanceof DefaultFlagsProvider) { continue; } ...

I think it's also possible to delegate the getUserValue call to getValue (so getValue calls getUserValue and falls back to DefaultFlagsProvider)
The reasoning is although it would take up slightly more cpu cycles, I think the method itself is useful.

I wonder how you think of getUserValue method. Is it a temporary or not temporary?

I split the method because I thought getUserValue method seems to be a temporary method(simply for migration and deleted afterwards). If it's not temporary, I think it's better to add ignoreDefaultFlags.

ref: #5029 (comment)

I wonder how you think of getUserValue method. Is it a temporary or not temporary?

Although temporary, we will probably keep the logic for a while (at least until 2.0)

On second thought, would it be simpler to just delete getUserValue and modify DefaultFlagsProvider#useOpenSsl, DefaultFlagsProvider#tlsEngineType to return null by default?

@jrhee17 I think we should preserve getUserValue because Flags#getValue throws new Error() when all the values retrieved by the FlagsProviders is null.

private static <T> T getValue(Function<FlagsProvider, @Nullable T> method, String flagName, Predicate<T> validator) { for (FlagsProvider provider : FLAGS_PROVIDERS) { try { final T value = method.apply(provider); if (value == null) { continue; } if (!validator.test(value)) { logger.warn("{}: {} ({}, validation failed)", flagName, value, provider.name()); continue; } logger.info("{}: {} ({})", flagName, value, provider.name()); return value; } catch (Exception ex) { logger.warn("{}: ({}, {})", flagName, provider.name(), ex.getMessage()); } } // Should never reach here because DefaultFlagsProvider always returns a normal value. throw new Error(); }

Ah, I see. Then we can probably do

if (ignoreDefaultFlags) { return null; } // Should never reach here because DefaultFlagsProvider always returns a normal value. throw new Error();

at the end.
So it's your call now. We can gather it into one method, which makes the method a little longer, or we can have separate methods. I'm fine with both. It's your call. 😉

Ok! I will separate methods because combining getValue and getUserValue will require a lot of changes when @Nullable has to be handled by the callers of getValue method.

Any idea on how to delegate @nullable getUserValue call to non-@nullable getValue ?

I meant something like the following. Having said this, I think I'm fine with the current approach:

diff --git a/core/src/main/java/com/linecorp/armeria/common/Flags.java b/core/src/main/java/com/linecorp/armeria/common/Flags.java index ff40a0de6..e30115a4c 100644 --- a/core/src/main/java/com/linecorp/armeria/common/Flags.java +++ b/core/src/main/java/com/linecorp/armeria/common/Flags.java @@ -105,7 +105,6 @@ public final class Flags { .sorted(Comparator.comparingInt(FlagsProvider::priority).reversed()) .collect(Collectors.toList()); flagsProviders.add(0, SystemPropertyFlagsProvider.INSTANCE); - flagsProviders.add(DefaultFlagsProvider.INSTANCE); FLAGS_PROVIDERS = ImmutableList.copyOf(flagsProviders); } @@ -561,8 +560,9 @@ public final class Flags { return; } - final Boolean useOpenSsl = getUserValue(FlagsProvider::useOpenSsl, "useOpenSsl"); - final TlsEngineType tlsEngineTypeValue = getUserValue(FlagsProvider::tlsEngineType, "tlsEngineType"); + final Boolean useOpenSsl = getUserValue(FlagsProvider::useOpenSsl, "useOpenSsl", ignored -> true); + final TlsEngineType tlsEngineTypeValue = getUserValue(FlagsProvider::tlsEngineType, "tlsEngineType", + ignored -> true); if (useOpenSsl == null) { tlsEngineType = tlsEngineTypeValue != null ? tlsEngineTypeValue : TlsEngineType.OPENSSL; @@ -1549,28 +1549,16 @@ public final class Flags { private static <T> T getValue(Function<FlagsProvider, @Nullable T> method, String flagName, Predicate<T> validator) { - for (FlagsProvider provider : FLAGS_PROVIDERS) { - try { - final T value = method.apply(provider); - if (value == null) { - continue; - } - if (!validator.test(value)) { - logger.warn("{}: {} ({}, validation failed)", flagName, value, provider.name()); - continue; - } - logger.info("{}: {} ({})", flagName, value, provider.name()); - return value; - } catch (Exception ex) { - logger.warn("{}: ({}, {})", flagName, provider.name(), ex.getMessage()); - } + final T t = getUserValue(method, flagName, validator); + if (t != null) { + return t; } - // Should never reach here because DefaultFlagsProvider always returns a normal value. - throw new Error(); + return method.apply(DefaultFlagsProvider.INSTANCE); } @Nullable - private static <T> T getUserValue(Function<FlagsProvider, @Nullable T> method, String flagName) { + private static <T> T getUserValue(Function<FlagsProvider, @Nullable T> method, String flagName, + Predicate<T> validator) { for (FlagsProvider provider : FLAGS_PROVIDERS) { if (provider instanceof DefaultFlagsProvider) { continue; @@ -1581,6 +1569,10 @@ public final class Flags { if (value == null) { continue; } + if (!validator.test(value)) { + logger.warn("{}: {} ({}, validation failed)", flagName, value, provider.name()); + continue; + } logger.info("{}: {} ({})", flagName, value, provider.name()); return value;

Oh, thanks for the great detail. I think above approach looks much clean. Let me apply above first and see whether no tests fail.

@jrhee17
I think calling getUserValue from getValue adds some overhead because of provider instanceof DefaultFlagsProvider(even though we don't need except for useOpenSsl and tlsEngineType). But I think the overheads are small. I want to first ask you whether this overheads are negligible.

core/src/main/java/com/linecorp/armeria/common/Flags.java

jrhee17

Left some minor comments, but mostly happy about the changes!

jrhee17 · 2023-08-24T13:32:21Z

core/src/main/java/com/linecorp/armeria/common/Flags.java

@@ -1506,6 +1535,29 @@ private static <T> T getValue(Function<FlagsProvider, @Nullable T> method,
        throw new Error();
    }

+    @Nullable
+    private static <T> T getUserValue(Function<FlagsProvider, @Nullable T> method, String flagName) {


I think it's also possible to delegate the getUserValue call to getValue (so getValue calls getUserValue and falls back to DefaultFlagsProvider)
The reasoning is although it would take up slightly more cpu cycles, I think the method itself is useful.

core/src/main/java/com/linecorp/armeria/common/FlagsProvider.java

core/src/main/java/com/linecorp/armeria/common/SystemPropertyFlagsProvider.java

it/flags-provider/src/test/java/com/linecorp/armeria/common/FlagsProviderTest.java

jrhee17 · 2023-08-24T13:42:33Z

it/flags-provider/src/test/java/com/linecorp/armeria/common/FlagsProviderTest.java

@@ -57,7 +58,6 @@ void reloadFlags() throws ClassNotFoundException {

    @Test
    void overrideDefaultFlagsProvider() throws Throwable {
-        assertFlags("useOpenSsl").isEqualTo(false);


Could this be converted to the following?

assertFlags("tlsEngineType").equals(TlsEngineType.OPENSSL);

Sure! I'll add that.

Btw, after adding above test code, I don't know why this keeps on failing with below exceptions. To my expectation and debugging, it should run fine...

Added code.

assertFlags("tlsEngineType").isEqualTo(TlsEngineType.OPENSSL);

Exception message:

FlagsProviderTest > overrideDefaultFlagsProvider() FAILED java.lang.IllegalAccessException: no such method: com.linecorp.armeria.common.Flags.tlsEngineType()TlsEngineType/invokeStatic at java.base/java.lang.invoke.MemberName.makeAccessException(MemberName.java:972) at java.base/java.lang.invoke.MemberName$Factory.resolveOrFail(MemberName.java:1117) at java.base/java.lang.invoke.MethodHandles$Lookup.resolveOrFail(MethodHandles.java:3664) at java.base/java.lang.invoke.MethodHandles$Lookup.findStatic(MethodHandles.java:2598) at com.linecorp.armeria.common.FlagsProviderTest.assertFlags(FlagsProviderTest.java:163) at com.linecorp.armeria.common.FlagsProviderTest.overrideDefaultFlagsProvider(FlagsProviderTest.java:61) Caused by: java.lang.LinkageError: bad method type alias: ()TlsEngineType not visible from class com.linecorp.armeria.common.Flags at java.base/java.lang.invoke.MemberName.checkForTypeAlias(MemberName.java:878) at java.base/java.lang.invoke.MemberName$Factory.resolve(MemberName.java:1089) at java.base/java.lang.invoke.MemberName$Factory.resolveOrFail(MemberName.java:1114) ... 4 more

I guess the TlsEngineType was loaded from the default class loader, whereas the assertion is using the FlagsClassLoader.

Can you try the following?

user@AL02437565 armeria % git diff diff --git a/it/flags-provider/src/test/java/com/linecorp/armeria/common/FlagsProviderTest.java b/it/flags-provider/src/test/java/com/linecorp/armeria/common/FlagsProviderTest.java index a010976bf..619bfd3eb 100644 --- a/it/flags-provider/src/test/java/com/linecorp/armeria/common/FlagsProviderTest.java +++ b/it/flags-provider/src/test/java/com/linecorp/armeria/common/FlagsProviderTest.java @@ -158,11 +158,8 @@ class FlagsProviderTest { } private ObjectAssert<Object> assertFlags(String flagsMethod) throws Throwable { - final Lookup lookup = MethodHandles.publicLookup(); - final MethodHandle method = - lookup.findStatic(flags, flagsMethod, MethodType.methodType( - Flags.class.getMethod(flagsMethod).getReturnType())); - return assertThat(method.invoke()); + Method method = flags.getDeclaredMethod(flagsMethod); + return assertThat(method.invoke(null)); } private static class FlagsClassLoader extends ClassLoader { user@AL02437565 armeria %

I also realized it should actually be isNotEqualTo (following the previous implementation)

core/src/test/java/com/linecorp/armeria/internal/common/util/SslContextUtilTest.java

jrhee17 · 2023-08-24T13:47:21Z

core/src/test/java/com/linecorp/armeria/common/FlagsTest.java

+        System.setProperty("com.linecorp.armeria.useOpenSsl", "false");
+        System.setProperty("com.linecorp.armeria.tlsEngineType", "OPENSSL");


I believe these values will be set while the jvm is running. Do you mind using either assumeThat or @SetSystemProperty instead?

Suggested change

System.setProperty("com.linecorp.armeria.useOpenSsl", "false");

System.setProperty("com.linecorp.armeria.tlsEngineType", "OPENSSL");

System.setProperty("com.linecorp.armeria.useOpenSsl", "false");

System.setProperty("com.linecorp.armeria.tlsEngineType", "OPENSSL");

I'll change the test to use @SetSystemProperty.
cf) I think this test leads to the problems you mentioned. Should we consider setting ways to prevent above test running in parallel(even if we use --parallel flag)

codecov · 2023-09-02T05:59:48Z

Codecov Report

Attention: Patch coverage is 48.07692% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 74.08%. Comparing base (655d48c) to head (13e6e79).

Files	Patch %	Lines
...c/main/java/com/linecorp/armeria/common/Flags.java	42.42%	12 Missing and 7 partials ⚠️
...rp/armeria/common/SystemPropertyFlagsProvider.java	25.00%	5 Missing and 1 partial ⚠️
.../linecorp/armeria/common/DefaultFlagsProvider.java	0.00%	1 Missing ⚠️
...ava/com/linecorp/armeria/server/ServerBuilder.java	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #5029       +/-   ##
===========================================
+ Coverage        0   74.08%   +74.08%     
- Complexity      0    20973    +20973     
===========================================
  Files           0     1819     +1819     
  Lines           0    77296    +77296     
  Branches        0     9874     +9874     
===========================================
+ Hits            0    57267    +57267     
- Misses          0    15369    +15369     
- Partials        0     4660     +4660

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2023-09-02T06:46:26Z

🔍 Build Scan® (commit: `13e6e79`)

Job name	Status	Build Scan®
build-windows-latest-jdk-19	✅	https://ge.armeria.dev/s/o7yff2bi2g7ca
build-self-hosted-unsafe-jdk-8	✅	https://ge.armeria.dev/s/pz2eljciijucq
build-self-hosted-unsafe-jdk-19-snapshot-blockhound	✅	https://ge.armeria.dev/s/b2uttkxb46u4g
build-self-hosted-unsafe-jdk-17-min-java-17-coverage	✅	https://ge.armeria.dev/s/bsujgvqf4nf4u
build-self-hosted-unsafe-jdk-17-min-java-11	✅	https://ge.armeria.dev/s/xpbpcwrfcpjru
build-self-hosted-unsafe-jdk-17-leak	✅	https://ge.armeria.dev/s/iocoj4hrseroa
build-self-hosted-unsafe-jdk-11	✅	https://ge.armeria.dev/s/z5r4inxfljrr4
build-macos-12-jdk-19	✅	https://ge.armeria.dev/s/qcxx7fa3ygn3y

jrhee17

Looks almost done 👍

jrhee17 · 2023-09-04T14:06:01Z

core/src/main/java/com/linecorp/armeria/common/Flags.java

@@ -1506,6 +1535,29 @@ private static <T> T getValue(Function<FlagsProvider, @Nullable T> method,
        throw new Error();
    }

+    @Nullable
+    private static <T> T getUserValue(Function<FlagsProvider, @Nullable T> method, String flagName) {


I wonder how you think of getUserValue method. Is it a temporary or not temporary?

Although temporary, we will probably keep the logic for a while (at least until 2.0)

On second thought, would it be simpler to just delete getUserValue and modify DefaultFlagsProvider#useOpenSsl, DefaultFlagsProvider#tlsEngineType to return null by default?

seonWKim · 2023-09-14T22:53:17Z

@jrhee17

On second thought, would it be simpler to just delete getUserValue and modify DefaultFlagsProvider#useOpenSsl, DefaultFlagsProvider#tlsEngineType to return null by default?

We still have BaseFlagsProvider which sets useOpenSsl to false by default, so only modifying DefaultFlagsPRovider#useOpenSsl method to return null won't work. And as we have discussed in the above comments, if we let getValue method to return a null value, the @Nullable should be handled by all the Flags which require many code changes.

minwoox

Looks great! Thanks, @seonwoo960000! 😄

jrhee17 · 2023-09-18T15:19:02Z

We still have BaseFlagsProvider which sets useOpenSsl to false by default, so only modifying DefaultFlagsPRovider#useOpenSsl method to return null won't work.

BaseFlagsProvider is for an integration test, I'm not sure I follow the reasoning 😅

I think the current approach is fine for this iteration though

jrhee17

Looks good 👍 Thanks @seonwoo960000 🙇 👍 🙇

jrhee17 · 2023-09-18T15:23:58Z

core/src/main/java/com/linecorp/armeria/common/Flags.java

+     * <p>If {@link #tlsEngineType()} does not return {@link TlsEngineType#OPENSSL}, this also returns
+     * {@code false} no matter you specified the JVM option.


matching the javadoc in FlagsProvider

Suggested change

* <p>If {@link #tlsEngineType()} does not return {@link TlsEngineType#OPENSSL}, this also returns

* {@code false} no matter you specified the JVM option.

* <p>If {@link #tlsEngineType()} does not return {@link TlsEngineType#OPENSSL}, this also returns

* {@code false} no matter what the specified JVM option is.

I'll fix that right away 🏃‍♂️

seonWKim · 2023-09-18T23:58:28Z

We still have BaseFlagsProvider which sets useOpenSsl to false by default, so only modifying DefaultFlagsPRovider#useOpenSsl method to return null won't work.

BaseFlagsProvider is for an integration test, I'm not sure I follow the reasoning 😅.

I think the current approach is fine for this iteration though

Oh yeah, I think I've missed that point. Thank you for helping better understanding🥺 . Thank you so much of your detailed review(learned a lot!)

core/src/main/java/com/linecorp/armeria/common/util/TlsEngineType.java

ikhoon · 2023-10-18T03:19:25Z

core/src/main/java/com/linecorp/armeria/common/Flags.java

-            Flags.useOpenSsl = false;
-            dumpOpenSslInfo = false;
-            return;
-        }
        if (!OpenSsl.isAvailable()) {


This seems a regression of #2184
Should we check OpenSsl.isAvailable() lazily when other constrains are met?

Sorry for the late reply 😅
If the cost of OpenSsl.isAvailable() is high, I think it's better to remain as-is.

…nSslAndDumpOpenSslInfo()`

- Refactor `getValue` to delegate some logic into `getUserValue` - Fix documentation for uniformity

seonWKim · 2024-03-06T13:43:11Z

@ikhoon Just a ping 😄.

jrhee17

Looks good 👍 Thanks! 🙇 👍 🙇

ikhoon

Thanks, @seonwoo960000! 🚀🚀

ikhoon · 2024-04-03T09:12:47Z

@minwoox (Not urgent) Could you take another look? I've re-requested a review.

…oviders

minwoox

Still looks good! Thanks!
I pushed a small patch that

Adds UnstableApi
Removes DefaultFlagsProvider.INSTANCE from flagsProrivers.

seonWKim requested review from ikhoon, jrhee17, minwoox and trustin as code owners July 13, 2023 01:11

seonWKim changed the title ~~Add tls engine type enum~~ Add TlsEngineType enum Jul 14, 2023

ikhoon added the new feature label Jul 17, 2023

ikhoon reviewed Jul 17, 2023

View reviewed changes

core/src/main/java/com/linecorp/armeria/common/FlagsProvider.java Show resolved Hide resolved

core/src/main/java/com/linecorp/armeria/common/Flags.java Outdated Show resolved Hide resolved

core/src/main/java/com/linecorp/armeria/common/Flags.java Outdated Show resolved Hide resolved

seonWKim force-pushed the add-tlsEngineType-enum branch 2 times, most recently from 3c99037 to 9bd86a5 Compare July 17, 2023 22:38

seonWKim requested a review from ikhoon July 27, 2023 05:35

seonWKim force-pushed the add-tlsEngineType-enum branch from 9bd86a5 to 027746c Compare July 27, 2023 05:45

ikhoon reviewed Jul 31, 2023

View reviewed changes

ikhoon mentioned this pull request Aug 2, 2023

Use fewer event loops when using io_uring as transport #5089

Merged

seonWKim force-pushed the add-tlsEngineType-enum branch from 027746c to 6d2790e Compare August 2, 2023 09:49

minwoox reviewed Aug 24, 2023

View reviewed changes

minwoox added this to the 1.26.0 milestone Aug 24, 2023

jrhee17 reviewed Aug 24, 2023

View reviewed changes

seonWKim force-pushed the add-tlsEngineType-enum branch from b04c5e4 to 1e2b206 Compare September 2, 2023 12:19

jrhee17 reviewed Sep 4, 2023

View reviewed changes

seonWKim force-pushed the add-tlsEngineType-enum branch from 39a021c to 9a84c82 Compare September 14, 2023 12:26

minwoox approved these changes Sep 15, 2023

View reviewed changes

jrhee17 approved these changes Sep 18, 2023

View reviewed changes

seonWKim force-pushed the add-tlsEngineType-enum branch from 9a84c82 to 9a87460 Compare September 19, 2023 00:14

ikhoon reviewed Oct 18, 2023

View reviewed changes

minwoox removed this from the 1.26.0 milestone Oct 20, 2023

minwoox added this to the 1.27.0 milestone Oct 20, 2023

seonWKim added 7 commits December 3, 2023 13:21

Add TlsEngineType enum to Flags and FlagsProvider

5398d28

Deprecate useOpenSsl

91cabbb

Fix test related to useOpenSsl

c22726b

Use user defined values of useOpenSsl and tlsEngineType in `setUseOpe…

f1fdee8

…nSslAndDumpOpenSslInfo()`

Apply comments

14ef58c

Fix failing tset

711c984

Apply comments

0936f9a

- Refactor `getValue` to delegate some logic into `getUserValue` - Fix documentation for uniformity

seonWKim force-pushed the add-tlsEngineType-enum branch from 42a8ab6 to 0936f9a Compare December 3, 2023 04:21

ikhoon modified the milestones: 1.27.0, 1.28.0 Jan 24, 2024

ikhoon and others added 3 commits March 25, 2024 21:29

Lazily check OpenSsl.isAvailable

ceb9f82

log available cause only when flag is set

b16c72c

Merge branch 'main' into add-tlsEngineType-enum

482be81

ikhoon requested review from jrhee17 and minwoox March 25, 2024 12:50

lint failure

e1ad514

jrhee17 approved these changes Apr 2, 2024

View reviewed changes

ikhoon approved these changes Apr 3, 2024

View reviewed changes

Add UnstableApi and remove DefaultFlagsProvider.INSTANCE from flagsPr…

e471399

…oviders

minwoox approved these changes Apr 3, 2024

View reviewed changes

Merge branch 'main' into add-tlsEngineType-enum

13e6e79

jrhee17 merged commit 33ab3bb into line:main Apr 3, 2024
18 checks passed

		System.setProperty("com.linecorp.armeria.useOpenSsl", "false");
		System.setProperty("com.linecorp.armeria.tlsEngineType", "OPENSSL");

		* <p>If {@link #tlsEngineType()} does not return {@link TlsEngineType#OPENSSL}, this also returns
		* {@code false} no matter you specified the JVM option.

Add TlsEngineType enum #5029

Add TlsEngineType enum #5029

Conversation

seonWKim commented Jul 13, 2023

Choose a reason for hiding this comment

seonWKim Aug 2, 2023 • edited

Choose a reason for hiding this comment

minwoox left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

seonWKim Sep 2, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

seonWKim Sep 9, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

seonWKim Sep 14, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

seonWKim Sep 19, 2023 • edited

Choose a reason for hiding this comment

jrhee17 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

seonWKim Sep 2, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Sep 2, 2023 • edited

Codecov Report

github-actions bot commented Sep 2, 2023 • edited

🔍 Build Scan® (commit: 13e6e79)

jrhee17 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

seonWKim commented Sep 14, 2023 • edited

minwoox left a comment

Choose a reason for hiding this comment

jrhee17 commented Sep 18, 2023

jrhee17 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

seonWKim commented Sep 18, 2023 • edited

Choose a reason for hiding this comment

seonWKim Dec 1, 2023 • edited

Choose a reason for hiding this comment

seonWKim commented Mar 6, 2024

jrhee17 left a comment

Choose a reason for hiding this comment

ikhoon left a comment

Choose a reason for hiding this comment

ikhoon commented Apr 3, 2024

minwoox left a comment • edited

Choose a reason for hiding this comment

Add `TlsEngineType` enum #5029

Add `TlsEngineType` enum #5029

seonWKim Aug 2, 2023 •

edited

seonWKim Sep 2, 2023 •

edited

seonWKim Sep 9, 2023 •

edited

seonWKim Sep 14, 2023 •

edited

seonWKim Sep 19, 2023 •

edited

seonWKim Sep 2, 2023 •

edited

codecov bot commented Sep 2, 2023 •

edited

github-actions bot commented Sep 2, 2023 •

edited

🔍 Build Scan® (commit: `13e6e79`)

seonWKim commented Sep 14, 2023 •

edited

seonWKim commented Sep 18, 2023 •

edited

seonWKim Dec 1, 2023 •

edited

minwoox left a comment •

edited