Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HttpHeaderNamesTest.httpHeaderNamesContainsAllFieldsInHttpHeadersInGuava() fails #5492

Closed
trustin opened this issue Mar 8, 2024 · 0 comments · Fixed by #5505
Closed

HttpHeaderNamesTest.httpHeaderNamesContainsAllFieldsInHttpHeadersInGuava() fails #5492

trustin opened this issue Mar 8, 2024 · 0 comments · Fixed by #5505
Labels
cleanup

Comments

@trustin
Copy link
Member

trustin commented Mar 8, 2024

It looks like we have two following header names missing in HttpHeaderNames:

  • SEC_AD_AUCTION_FETCH
  • AD_AUCTION_SIGNALS

We could port them from Guava's HttpHeaders:
@trustin trustin added the cleanup label Mar 8, 2024
@thachlp thachlp mentioned this issue Mar 14, 2024
Merged
ikhoon pushed a commit that referenced this issue Mar 18, 2024
@thachlp
Fix HttpHeaderNamesTest as upgrade Guava (#5505)
ccb29fe 
### Motivation:
Fix `HttpHeaderNamesTest.
httpHeaderNamesContainsAllFieldsInHttpHeadersInGuava` fail

### Modifications:
- Add `SEC_AD_AUCTION_FETCH` and `AD_AUCTION_SIGNALS` to
`HttpHeaderNames`

Result:
Closes: #5492
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix HttpHeaderNamesTest as upgrade Guava thachlp/armeria
1 participant
@trustin