Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HttpHeaderNamesTest as upgrade Guava #5505

Merged
merged 1 commit into from Mar 18, 2024

Conversation

thachlp
Copy link
Member

@thachlp thachlp commented Mar 14, 2024

Motivation:

Fix HttpHeaderNamesTest. httpHeaderNamesContainsAllFieldsInHttpHeadersInGuava fail

Modifications:

  • Add SEC_AD_AUCTION_FETCH and AD_AUCTION_SIGNALS to HttpHeaderNames

Result:
Closes: #5492

@CLAassistant
Copy link

CLAassistant commented Mar 14, 2024

CLA assistant check
All committers have signed the CLA.

* Ad-Auction-Signals}</a> header field name.
*/
public static final AsciiString AD_AUCTION_SIGNALS = create("Ad-Auction-Signals");

Copy link
Member Author

@thachlp thachlp Mar 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thachlp thachlp changed the title Fix HttpHeaderNamesTest Fix HttpHeaderNamesTest as upgrade Guava Mar 16, 2024
Copy link
Contributor

@ikhoon ikhoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙇‍♂️

Copy link
Member

@minwoox minwoox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ikhoon ikhoon merged commit ccb29fe into line:main Mar 18, 2024
16 checks passed
@thachlp thachlp deleted the fix-test-header-names branch March 18, 2024 05:19
@ikhoon ikhoon added this to the 1.28.0 milestone Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HttpHeaderNamesTest.httpHeaderNamesContainsAllFieldsInHttpHeadersInGuava() fails
5 participants