Introduce Java 9 module compatibility #5543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation:
Some users are having issues with using Armeria as a Java 9 module
because:
- Armeria core JAR contains `module-info.class` from Bouncy Castle,
which should be removed during the shading process.
- Armeria doesn't define module metadata at all
Modifications:
- Updated `gradle-scripts` to exclude `module-info.class` while shading.
- This removes Bouncy Castle's `module-info.class` from the final JAR,
fixing the issue mentioned in the previous section.
- Updated `gradle-scripts` to auto-inject the `Automatic-Module-Name`
property into `META-INF/MANIFEST.MF` so that JVM auto-generates the
module metadata.
- Miscellaneous:
- Overwrote the `Created-By` property in `META-INF/MANIFEST.MF` so
that the manifest file's content doesn't change depending on JDK
version.
Result:
- (new feature) Armeria JARs are now Java modules.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5543 +/- ##
============================================
+ Coverage 74.04% 74.07% +0.02%
- Complexity 20871 20901 +30
============================================
Files 1809 1809
Lines 76857 76940 +83
Branches 9809 9833 +24
============================================
+ Hits 56912 56994 +82
+ Misses 15304 15297 -7
- Partials 4641 4649 +8 ☔ View full report in Codecov by Sentry. |
Co-authored-by: minux <songmw725@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Some users are having issues with using Armeria as a Java 9 module because:
module-info.classfrom Bouncy Castle, which should be removed during the shading process.Modifications:
gradle-scriptsto excludemodule-info.classwhile shading.module-info.classfrom the final JAR, fixing the issue mentioned in the previous section.gradle-scriptsto auto-inject theAutomatic-Module-Nameproperty intoMETA-INF/MANIFEST.MFso that JVM auto-generates the module metadata.Created-Byproperty inMETA-INF/MANIFEST.MFso that the manifest file's content doesn't change depending on JDK version.Result: