Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Java 9 module compatibility #5543

Merged
merged 5 commits into from
Apr 5, 2024
Merged

Commits on Mar 28, 2024

  1. Introduce Java 9 module compatibility

    Motivation:
    
    Some users are having issues with using Armeria as a Java 9 module
    because:
    
    - Armeria core JAR contains `module-info.class` from Bouncy Castle,
      which should be removed during the shading process.
    - Armeria doesn't define module metadata at all
    
    Modifications:
    
    - Updated `gradle-scripts` to exclude `module-info.class` while shading.
      - This removes Bouncy Castle's `module-info.class` from the final JAR,
        fixing the issue mentioned in the previous section.
    - Updated `gradle-scripts` to auto-inject the `Automatic-Module-Name`
      property into `META-INF/MANIFEST.MF` so that JVM auto-generates the
      module metadata.
    - Miscellaneous:
      - Overwrote the `Created-By` property in `META-INF/MANIFEST.MF` so
        that the manifest file's content doesn't change depending on JDK
        version.
    
    Result:
    
    - (new feature) Armeria JARs are now Java modules.
    trustin committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    df4e216 View commit details
    Browse the repository at this point in the history
  2. Fix names

    trustin committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    8e181c3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9040136 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8b34267 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2024

  1. Update gradle/scripts/lib/java.gradle

    Co-authored-by: minux <songmw725@gmail.com>
    trustin and minwoox committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    a1de02d View commit details
    Browse the repository at this point in the history