Fix a bug where a GrpcDocServicePlugin does not handle exact path map… #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pings
Motivation:
When a user adds a GrpcService with ServerBuilder.service(ServiceWithPathMappings),
GrpcDocServicePlugin fails to add the service endpoints to ServiceSpecification.
To work around this issue, a user has to fall back to the old usage:
ServerBuilder sb = ...;
sb.serviceUnder("/", grpcService); // Works
sb.service(grpcService); // Does not work
Modifications:
- Update the endpoint detection logic in GrpcDocServicePlugin
Result:
- Fixes line#1136
anuraaga
approved these changes
Apr 10, 2018
Codecov Report
@@ Coverage Diff @@
## master #1138 +/- ##
==========================================
- Coverage 72.48% 72.47% -0.02%
==========================================
Files 509 509
Lines 22789 22790 +1
Branches 2825 2827 +2
==========================================
- Hits 16519 16516 -3
- Misses 4768 4770 +2
- Partials 1502 1504 +2
Continue to review full report at Codecov.
|
hyangtack
approved these changes
Apr 11, 2018
|
Thanks, reviewers! |
fmguerreiro
pushed a commit
to fmguerreiro/armeria
that referenced
this pull request
Sep 19, 2020
line#1138) Motivation: When a user adds a GrpcService with ServerBuilder.service(ServiceWithPathMappings), GrpcDocServicePlugin fails to add the service endpoints to ServiceSpecification. To work around this issue, a user has to fall back to the old usage: ServerBuilder sb = ...; sb.serviceUnder("/", grpcService); // Works sb.service(grpcService); // Does not work Modifications: - Update the endpoint detection logic in GrpcDocServicePlugin Result: - Fixes line#1136
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…pings
Motivation:
When a user adds a GrpcService with ServerBuilder.service(ServiceWithPathMappings),
GrpcDocServicePlugin fails to add the service endpoints to ServiceSpecification.
To work around this issue, a user has to fall back to the old usage:
Modifications:
Result: