Use Class.getDeclaredField() instead of getField() when fetching Thrift metadata.

[edgao]

Related: #1728

Motivation:

When a user builds a .thrift file with the private-members option enabled,
Armeria fails to find some fields in the generated code.

Modifications:

• Use Class.getDeclaredField() instead of getField().

Result:

• Fixes armeria-thrift does not handle service method throwing exception #1728

[CLAassistant]

All committers have signed the CLA.

[edgao]

Update: Turns out this is because we use the java:private-members option when generating thrift code, so the unit test I added doesn't actually do anything. Specifically, without this option set, the TestService class contains this internal class:

public static class ping_result implements org.apache.thrift.TBase<ping_result, ping_result._Fields>, java.io.Serializable, Cloneable, Comparable<ping_result>   {
    // <snip>
    public TestException te; // required
    // <snip>
}

But with private-members enabled, te is a private field, and so getFields does not return it.

[trustin]

Thanks for the detailed analysis. Could you remove the new test method since we now know it does not add anything to the test?

[codecov]

Codecov Report

Merging #1729 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #1729      +/-   ##
============================================
+ Coverage     72.86%   72.89%   +0.03%     
- Complexity     8121     8128       +7     
============================================
  Files           734      734              
  Lines         32374    32374              
  Branches       3980     3980              
============================================
+ Hits          23589    23600      +11     
+ Misses         6746     6741       -5     
+ Partials       2039     2033       -6

Impacted Files	Coverage Δ	Complexity Δ
...necorp/armeria/internal/thrift/ThriftFunction.java	78.86% <100%> (ø)	45 <0> (ø)	⬇️
...rp/armeria/common/stream/DefaultStreamMessage.java	89.28% <0%> (-1.43%)	53% <0%> (-1%)
...inecorp/armeria/server/grpc/ArmeriaServerCall.java	86.87% <0%> (+0.38%)	84% <0%> (+1%)	⬆️
...inecorp/armeria/server/HttpResponseSubscriber.java	81.86% <0%> (+1.39%)	59% <0%> (+3%)	⬆️
...a/common/grpc/protocol/ArmeriaMessageDeframer.java	70.81% <0%> (+1.43%)	47% <0%> (+2%)	⬆️
...om/linecorp/armeria/client/HttpSessionHandler.java	61.2% <0%> (+1.72%)	29% <0%> (+1%)	⬆️
...spring/web/reactive/ArmeriaServerHttpResponse.java	77.22% <0%> (+1.98%)	29% <0%> (+1%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d0e58e...6d2694d. Read the comment docs.

[trustin]

@hyangtack Please review. :-)

[hyangtack]

Nice catch! 👍

[trustin]

Thanks again, @edgao !

[edgao]

thanks for the super quick turnaround! just curious - do you know when the next official release will be? (not a blocker for us since we've built a patched jar)