Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add brave module which supersedes zipkin module #1840

Merged
merged 5 commits into from Jul 2, 2019
Merged

Add brave module which supersedes zipkin module #1840

merged 5 commits into from Jul 2, 2019

Commits on Jul 1, 2019

  1. Add HttpTracing(Client|Service)Builder 

    Motivation:
A user currently has to build `Tracing` by him/herself and set `currentTraceContext` manually.
We could add `HttpTracing(Client|Service)Builder` which builds a `Tracing` for a user.

Modifications:
- Add `HttpTracing(Client|Service)`Builder
- May fix a bug where `decorateScope` is not called
- Deprecation
  - The consturctor of `HttpTracingService` is not public anymore. A user should use the builder or the static factory method.

Result:
- A user can easidy build an `HttpTracing(Client|Service)` using builders.
    @minwoox
    minwoox committed Jul 1, 2019
    Configuration menu
    Copy the full SHA
    f225c07 View commit details
    Browse the repository at this point in the history

  2. Add brave module

    @minwoox
    minwoox committed Jul 1, 2019
    Configuration menu
    Copy the full SHA
    5a79d60 View commit details
    Browse the repository at this point in the history

  3. Address comments by @anuraaga

    @minwoox
    minwoox committed Jul 1, 2019
    Configuration menu
    Copy the full SHA
    f9ee5d1 View commit details
    Browse the repository at this point in the history

  4. Address comments by @trustin

    @minwoox
    minwoox committed Jul 1, 2019
    Configuration menu
    Copy the full SHA
    67ee121 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2019

  1. Update version

    @minwoox
    minwoox committed Jul 2, 2019
    Configuration menu
    Copy the full SHA
    4c98058 View commit details
    Browse the repository at this point in the history